Skip to content

Check if bazel is enabled before attempting to load a workspace to fi… #4154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Check if bazel is enabled before attempting to load a workspace to fi… #4154

wants to merge 1 commit into from

Conversation

DaveShuckerow
Copy link
Contributor

…x slowness in #4142

@devoncarew
Copy link
Member

I'll take a look at the PR; in the meantime, it looks like some related tests are failing:

io.flutter.bazel.WorkspaceTest
    ✘ canLoadWorkspaceWithConfigFileAndScriptInReadonly
      java.lang.AssertionError: expected a workspace
          at io.flutter.bazel.WorkspaceTest.canLoadWorkspaceWithConfigFileAndScriptInReadonly(WorkspaceTest.java:84)
    ✘ canLoadWorkspaceWithConfigFile
      java.lang.AssertionError: expected a workspace
          at io.flutter.bazel.WorkspaceTest.canLoadWorkspaceWithConfigFile(WorkspaceTest.java:59)
    ✘ canLoadWorkspaceWithoutConfigFile
      java.lang.AssertionError: expected a workspace
          at io.flutter.bazel.WorkspaceTest.canLoadWorkspaceWithoutConfigFile(WorkspaceTest.java:36)

devoncarew
devoncarew approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (w/ a green travis)

@jacob314
Copy link
Contributor

jacob314 commented Dec 3, 2019

Fix tests to enable bazel.
https://github.com/jacob314/flutter-intellij/pull/new/slowness

@jacob314
Copy link
Contributor

jacob314 commented Dec 3, 2019

#4164

@jacob314
Copy link
Contributor

jacob314 commented Dec 4, 2019

Closing as I've landed this with #4164

@jacob314 jacob314 closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaveShuckerow @devoncarew @jacob314 @googlebot