Skip to content

[WIP] Binary artifacts, but cannot be merged #6083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

stevemessick
Copy link
Member

Fixes #6072

@Hixie
Copy link

Hixie commented Apr 5, 2022

These files are in violation of Google's third-party policies.

All third-party files must be in a third_party subdirectory with clear license terms.

@Hixie
Copy link

Hixie commented Apr 5, 2022

(Separate from that, you'll need to have us update the central configuration — our allstar configuration disables per-repo configs so that we can audit it all easily, so this PR won't actually work.)

@stevemessick
Copy link
Member Author

Thanks for the clarification!

@stevemessick stevemessick changed the title Binary artifacts [WIP] Binary artifacts, but cannot be merged Apr 5, 2022
@godofredoc
Copy link
Contributor

Thanks, @Hixie. I'll ask if we can opt out individual files.

@stevemessick
Copy link
Member Author

We should include a script to run the Gradle wrapper when it moves into third_party. The alternative would be symlinks, which just cause problems on Windows, so let's not do that. We will need scripts for both Mac/Linux and Windows.

@Hixie do we have a deadline for compliance?

@godofredoc
Copy link
Contributor

We should include a script to run the Gradle wrapper when it moves into third_party. The alternative would be symlinks, which just cause problems on Windows, so let's not do that. We will need scripts for both Mac/Linux and Windows.

@Hixie do we have a deadline for compliance?

There is no deadline yet, but given that having binaries checked in is consider a high risk I'd recommend that we aim for <2 weeks.

For the next step I'll opt out flutter-intellij temporarily while we work towards the final solution.

@blasten are there any java third party dependency management best practices that can help us here?

@stevemessick
Copy link
Member Author

Thanks @godofredoc! We shouldn't need two weeks. #6087 will take care of it.

@stevemessick
Copy link
Member Author

Close this, since it can't be merged and another PR (#6087) is out for review.

@stevemessick stevemessick deleted the binary-artifacts branch April 12, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project is out of compliance with Binary Artifacts policy: binaries present in source code
3 participants