Skip to content

Adds Flutter 3.3 support for flutter plugins library manager #6331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wagner1343
Copy link
Contributor

Since Flutter 3.3 flutter plugins library manager doesn't updates flutter plugins library correctly (see #6330).

This pull request fixes that by watching both .packages and .dart_tool/package_config.json files. It also uses dart plugin method to extract path map from package_config.json.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

…ich now updates the flutter plugin library when .dart_tool/package_config.json or .packages files are changed
Copy link
Member

@stevemessick stevemessick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! There are a few minor formatting errors, but otherwise this looks good. I'll patch it in and test it once the formatting is done.

@wagner1343
Copy link
Contributor Author

Fixed those formatting errors, thanks for the review!

Copy link
Member

@stevemessick stevemessick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants