Skip to content

Change Container to Placeholder in live templates #6390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

stevemessick
Copy link
Member

Fixes #6288

Also updates a couple settings that got changed when I moved to IntelliJ 2022.2 as the dev platform.

@DanTup We can coordinate the actual date that this is released, if you want.

@stevemessick stevemessick requested review from jwren and helin24 November 3, 2022 22:26
@stevemessick stevemessick merged commit d71b8b3 into master Nov 3, 2022
@stevemessick stevemessick deleted the use-placeholder branch November 3, 2022 23:34
@DanTup
Copy link
Contributor

DanTup commented Nov 7, 2022

@DanTup We can coordinate the actual date that this is released, if you want.

For most VS Code users this is coming from the server so will show up based on SDK version and probably not worth trying to sync.

I'll submit the SDK changes shortly, and do the same in the VS Code plugin for users on onlder SDKs that don't yet use server snippets. Thanks!

@DanTup
Copy link
Contributor

DanTup commented Nov 7, 2022

By the way - the goal of this was to reduce triggering lints, but while testing my change I noticed that without const you can also trigger a lint:

Screenshot 2022-11-07 at 13 10 19

So I think we should be using const Placeholder().

@stevemessick
Copy link
Member Author

Good point. I thought people would immediately change Placeholder to something else. But really, a reference to that class is effectively a TODO and those can exist a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change snippets to use Placeholder() instead of Container()
3 participants