Skip to content

add Open in Xcode for macOS #6791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2023
Merged

add Open in Xcode for macOS #6791

merged 4 commits into from
Jun 20, 2023

Conversation

edwinludik
Copy link
Contributor

I (hopefully) added an option "Open in Xcode". Does anyone else maybe have a test environment ready? I will test locally, opening PR to get feedback on the design question.

Design Question: I did not add a second action, using "flutter.xcode.open" for iOS and macOS, should it rather be refactored to use two different actions? Something like ["flutter.xcode.openiOS" and "flutter.xcode.openMacOS"] or ["flutter.xcode.open.iOS" and "flutter.xcode.open.macOS"] or something else?

Missing open MacOS module in xcode #6209

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

add macOS in description
add macOS to the description
Copy link
Member

@stevemessick stevemessick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please update AUTHORS if you want credit.

I have not tested it yet but it should be fine. I'll test before the next release.

Add Edwin
@edwinludik
Copy link
Contributor Author

Updated tx @stevemessick - feel free to let me know if you encounter any problems during the testing.

@stevemessick stevemessick merged commit 8d13924 into flutter:master Jun 20, 2023
@stevemessick
Copy link
Member

@edwinludik Works great, thanks! There is one inconsistency you might want to look into. If you don't have the ios directory open but you have ios selected, then the option is still available. That doesn't happen for macos but probably should. See `OpenInXcodeAction.findProjectFile()' for more details.

I'm planning to ship this as-is, but would be glad to incorporate a fix if you can get it to me in the next four days.

@edwinludik
Copy link
Contributor Author

I just added a change that I think will fix it?! I don't have a test environment so please let me know. tx!

@stevemessick
Copy link
Member

@edwinludik I think you need to open a new PR since this one has already been merged. Thanks!

@stevemessick
Copy link
Member

@edwinludik I fixed it in #6851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants