Skip to content

Remove the Outline window #7860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions flutter-idea/src/io/flutter/FlutterInitializer.java
Original file line number Diff line number Diff line change
@@ -38,7 +38,6 @@
import io.flutter.editor.FlutterSaveActionsManager;
import io.flutter.logging.FlutterConsoleLogManager;
import io.flutter.module.FlutterModuleBuilder;
import io.flutter.preview.PreviewViewFactory;
import io.flutter.pub.PubRoot;
import io.flutter.pub.PubRoots;
import io.flutter.run.FlutterReloadManager;
@@ -320,7 +319,6 @@ public void actionPerformed(@NotNull AnActionEvent event) {
private void initializeToolWindows(@NotNull Project project) {
// Start watching for Flutter debug active events.
FlutterViewFactory.init(project);
PreviewViewFactory.init(project);
RemainingDevToolsViewFactory.init(project);
DevToolsExtensionsViewFactory.init(project);
toolWindowsInitialized = true;
118 changes: 0 additions & 118 deletions flutter-idea/src/io/flutter/preview/DartElementPresentationUtil.java

This file was deleted.

23 changes: 0 additions & 23 deletions flutter-idea/src/io/flutter/preview/ModelUtils.java

This file was deleted.

887 changes: 0 additions & 887 deletions flutter-idea/src/io/flutter/preview/PreviewView.java

This file was deleted.

50 changes: 0 additions & 50 deletions flutter-idea/src/io/flutter/preview/PreviewViewFactory.java

This file was deleted.

51 changes: 0 additions & 51 deletions flutter-idea/src/io/flutter/preview/PreviewViewState.java

This file was deleted.

65 changes: 0 additions & 65 deletions flutter-idea/src/io/flutter/preview/WidgetEditToolbar.java
Original file line number Diff line number Diff line change
@@ -335,69 +335,4 @@ private void applyChangeAndShowException(SourceChange change) {
}
});
}

public void createPopupMenu(Component comp, int x, int y) {
// The corresponding tree item may have just been selected.
// Wait short time for receiving assists from the server.
// TODO(jacobr): this hard coded sleep seems like a hack. Figure out a
// more robust way to wait for all assists to be received.
for (int i = 0; i < 20 && actionToChangeMap.isEmpty(); i++) {
Uninterruptibles.sleepUninterruptibly(5, TimeUnit.MILLISECONDS);
}

final DefaultActionGroup group = new DefaultActionGroup();
boolean hasAction = false;
if (actionCenter.isEnabled()) {
hasAction = true;
group.add(new TextOnlyActionWrapper(actionCenter));
}
if (actionPadding.isEnabled()) {
hasAction = true;
group.add(new TextOnlyActionWrapper(actionPadding));
}
if (actionColumn.isEnabled()) {
hasAction = true;
group.add(new TextOnlyActionWrapper(actionColumn));
}
if (actionRow.isEnabled()) {
hasAction = true;
group.add(new TextOnlyActionWrapper(actionRow));
}
if (actionContainer.isEnabled()) {
hasAction = true;
group.add(new TextOnlyActionWrapper(actionContainer));
}
group.addSeparator();
if (actionExtractMethod.isEnabled()) {
hasAction = true;
group.add(new TextOnlyActionWrapper(actionExtractMethod));
}
if (actionExtractWidget.isEnabled()) {
hasAction = true;
group.add(new TextOnlyActionWrapper(actionExtractWidget));
}
group.addSeparator();
if (actionMoveUp.isEnabled()) {
hasAction = true;
group.add(new TextOnlyActionWrapper(actionMoveUp));
}
if (actionMoveDown.isEnabled()) {
hasAction = true;
group.add(new TextOnlyActionWrapper(actionMoveDown));
}
group.addSeparator();
if (actionRemove.isEnabled()) {
hasAction = true;
group.add(new TextOnlyActionWrapper(actionRemove));
}

// Don't show the empty popup.
if (!hasAction) {
return;
}

final ActionManager actionManager = ActionManager.getInstance();
final ActionPopupMenu popupMenu = actionManager.createActionPopupMenu(ActionPlaces.UNKNOWN, group);
popupMenu.getComponent().show(comp, x, y);
}
}
2 changes: 1 addition & 1 deletion flutter-idea/src/io/flutter/view/FlutterViewFactory.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2017 The Chromium Authors. All rights reserved.
* Copyright 2024 The Chromium Authors. All rights reserved.
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
14 changes: 0 additions & 14 deletions resources/META-INF/plugin.xml
Original file line number Diff line number Diff line change
@@ -306,12 +306,6 @@
topic="com.intellij.openapi.project.ProjectManagerListener"/>
</applicationListeners>

<projectListeners>
<listener class="io.flutter.view.FlutterViewFactory$FlutterViewListener" topic="com.intellij.openapi.wm.ex.ToolWindowManagerListener"/>
<listener class="io.flutter.preview.PreviewViewFactory$PreviewViewListener"
topic="com.intellij.openapi.wm.ex.ToolWindowManagerListener"/>
</projectListeners>

<extensionPoints>
<extensionPoint name="gradleSyncProvider" interface="io.flutter.android.GradleSyncProvider"/>
<extensionPoint name="colorPickerProvider" interface="io.flutter.editor.ColorPickerProvider"/>
@@ -379,14 +373,6 @@
<codeInsight.lineMarkerProvider language="Dart" implementationClass="io.flutter.editor.FlutterIconLineMarkerProvider"/>
<errorHandler implementation="io.flutter.FlutterErrorReportSubmitter"/>

<toolWindow id="Flutter Outline" anchor="right" icon="FlutterIcons.FlutterDefault"
factoryClass="io.flutter.preview.PreviewViewFactory"/>
<projectService serviceImplementation="io.flutter.preview.PreviewView" overrides="false"/>

<toolWindow id="Flutter Inspector" anchor="right" icon="FlutterIcons.DevToolsInspector"
factoryClass="io.flutter.view.FlutterViewFactory"/>
<projectService serviceImplementation="io.flutter.view.FlutterView" overrides="false"/>

<toolWindow id="Flutter Deep Links" anchor="right" icon="FlutterIcons.DevToolsDeepLinks" factoryClass="io.flutter.deeplinks.DeepLinksViewFactory" />
<toolWindow id="Flutter DevTools" anchor="right" icon="FlutterIcons.DevTools" factoryClass="io.flutter.devtools.RemainingDevToolsViewFactory" />
<toolWindow id="Flutter DevTools Extensions" anchor="right" icon="FlutterIcons.DevToolsExtensions" factoryClass="io.flutter.devtools.DevToolsExtensionsViewFactory" />
14 changes: 0 additions & 14 deletions resources/META-INF/plugin_template.xml
Original file line number Diff line number Diff line change
@@ -243,12 +243,6 @@
topic="com.intellij.openapi.project.ProjectManagerListener"/>
</applicationListeners>

<projectListeners>
<listener class="io.flutter.view.FlutterViewFactory$FlutterViewListener" topic="com.intellij.openapi.wm.ex.ToolWindowManagerListener"/>
<listener class="io.flutter.preview.PreviewViewFactory$PreviewViewListener"
topic="com.intellij.openapi.wm.ex.ToolWindowManagerListener"/>
</projectListeners>

<extensionPoints>
<extensionPoint name="gradleSyncProvider" interface="io.flutter.android.GradleSyncProvider"/>
<extensionPoint name="colorPickerProvider" interface="io.flutter.editor.ColorPickerProvider"/>
@@ -316,14 +310,6 @@
<codeInsight.lineMarkerProvider language="Dart" implementationClass="io.flutter.editor.FlutterIconLineMarkerProvider"/>
<errorHandler implementation="io.flutter.FlutterErrorReportSubmitter"/>

<toolWindow id="Flutter Outline" anchor="right" icon="FlutterIcons.FlutterDefault"
factoryClass="io.flutter.preview.PreviewViewFactory"/>
<projectService serviceImplementation="io.flutter.preview.PreviewView" overrides="false"/>

<toolWindow id="Flutter Inspector" anchor="right" icon="FlutterIcons.DevToolsInspector"
factoryClass="io.flutter.view.FlutterViewFactory"/>
<projectService serviceImplementation="io.flutter.view.FlutterView" overrides="false"/>

<toolWindow id="Flutter Deep Links" anchor="right" icon="FlutterIcons.DevToolsDeepLinks" factoryClass="io.flutter.deeplinks.DeepLinksViewFactory" />
<toolWindow id="Flutter DevTools" anchor="right" icon="FlutterIcons.DevTools" factoryClass="io.flutter.devtools.RemainingDevToolsViewFactory" />
<toolWindow id="Flutter DevTools Extensions" anchor="right" icon="FlutterIcons.DevToolsExtensions" factoryClass="io.flutter.devtools.DevToolsExtensionsViewFactory" />