Repair the support for Test with Coverage #8007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If successful, this will resolve flutter#7810 Delay is due to Gradle IJ (upstream IJ platform) issues, this work was blocked until this was resolved: flutter#7936
pq
approved these changes
Apr 4, 2025
| @@ -0,0 +1,58 @@ | |||
| /* | |||
| * Copyright 2021 The Chromium Authors. All rights reserved. | |||
There was a problem hiding this comment.
Should this be 2025? (Similarly for the other new files?)
| return roots.toArray(VirtualFile.EMPTY_ARRAY); | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe add a trailing newline here and below?
| final String filePath = file.getAbsolutePath(); | ||
| final int index = filePath.indexOf("coverage"); | ||
| if (index < 0) { | ||
| // TODO Define at least one class in data |
There was a problem hiding this comment.
Is it standard to include a username?
| addLineCount(line.substring(DATA_LABEL.length())); | ||
| } | ||
| else if (line.startsWith(FILE_LABEL)) { | ||
| //currentFile = Paths.get(line.substring(FILE_LABEL.length())).normalize(); |
There was a problem hiding this comment.
Maybe remove the commented code?
| } | ||
| catch (NumberFormatException ex) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
Aside: surprising that there isn't some kind of "safe" parseInt...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If successful, this will resolve #7810
Delay is due to Gradle IJ (upstream IJ platform) issues, this work was blocked until this was resolved: #7936