Skip to content

[perf] create action presentations lazily #8187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

[perf] create action presentations lazily #8187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4c990a
[perf] create action presentations lazily
pq May 13, 2025
0574be2
regen
pq May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions flutter-idea/src/io/flutter/actions/DeviceSelectorRefresherAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,15 @@
*/
package io.flutter.actions;

import com.intellij.openapi.actionSystem.*;
import com.intellij.openapi.actionSystem.ActionUpdateThread;
import com.intellij.openapi.actionSystem.AnAction;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.project.Project;
import icons.FlutterIcons;
import io.flutter.run.daemon.DeviceService;
import io.flutter.utils.FlutterModuleUtils;
import org.jetbrains.annotations.NotNull;

public class DeviceSelectorRefresherAction extends AnAction {
public DeviceSelectorRefresherAction() {
super(FlutterIcons.RefreshItems);
}

@Override
public void actionPerformed(@NotNull AnActionEvent e) {
final Project project = e.getProject();
Expand Down
4 changes: 0 additions & 4 deletions flutter-idea/src/io/flutter/actions/RestartFlutterDaemonAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@
import org.jetbrains.annotations.NotNull;

public class RestartFlutterDaemonAction extends AnAction {
public RestartFlutterDaemonAction() {
super("Refresh");
}

@Override
public void actionPerformed(AnActionEvent event) {
final Project project = event.getProject();
Expand Down
13 changes: 4 additions & 9 deletions flutter-idea/src/io/flutter/actions/RunFlutterAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

import javax.swing.*;
import java.util.ArrayList;
import java.util.List;
import java.util.Objects;
Expand All @@ -35,14 +34,10 @@ public abstract class RunFlutterAction extends AnAction {
private final @NotNull FlutterLaunchMode myLaunchMode;
private final @NotNull String myExecutorId;

public RunFlutterAction(@NotNull String text,
@NotNull String detailedTextKey,
@NotNull String description,
@NotNull Icon icon,
@NotNull FlutterLaunchMode launchMode,
@NotNull String executorId) {
super(text, description, icon);

public RunFlutterAction(
@NotNull String detailedTextKey,
@NotNull FlutterLaunchMode launchMode,
@NotNull String executorId) {
myDetailedTextKey = detailedTextKey;
myLaunchMode = launchMode;
myExecutorId = executorId;
Expand Down
6 changes: 1 addition & 5 deletions flutter-idea/src/io/flutter/actions/RunProfileFlutterApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,13 @@
*/
package io.flutter.actions;

import com.intellij.icons.AllIcons;
import com.intellij.openapi.wm.ToolWindowId;
import io.flutter.FlutterBundle;
import io.flutter.run.FlutterLaunchMode;

public class RunProfileFlutterApp extends RunFlutterAction {
public static final String TEXT = FlutterBundle.message("app.profile.action.text");
public static final String DESCRIPTION = FlutterBundle.message("app.profile.action.description");
private static final String TEXT_DETAIL_MSG_KEY = "app.profile.config.action.text";

public RunProfileFlutterApp() {
super(TEXT, TEXT_DETAIL_MSG_KEY, DESCRIPTION, AllIcons.Actions.Execute, FlutterLaunchMode.PROFILE, ToolWindowId.RUN);
super(TEXT_DETAIL_MSG_KEY, FlutterLaunchMode.PROFILE, ToolWindowId.RUN);
}
}
6 changes: 1 addition & 5 deletions flutter-idea/src/io/flutter/actions/RunReleaseFlutterApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,13 @@
*/
package io.flutter.actions;

import com.intellij.icons.AllIcons;
import com.intellij.openapi.wm.ToolWindowId;
import io.flutter.FlutterBundle;
import io.flutter.run.FlutterLaunchMode;

public class RunReleaseFlutterApp extends RunFlutterAction {
public static final String TEXT = FlutterBundle.message("app.release.action.text");
public static final String DESCRIPTION = FlutterBundle.message("app.release.action.description");
private static final String TEXT_DETAIL_MSG_KEY = "app.release.config.action.text";

public RunReleaseFlutterApp() {
super(TEXT, TEXT_DETAIL_MSG_KEY, DESCRIPTION, AllIcons.Actions.Execute, FlutterLaunchMode.RELEASE, ToolWindowId.RUN);
super(TEXT_DETAIL_MSG_KEY, FlutterLaunchMode.RELEASE, ToolWindowId.RUN);
}
}
9 changes: 6 additions & 3 deletions resources/META-INF/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@
icon="FlutterIcons.Phone"/>
<action id="Flutter.DeviceSelectorRefresher" class="io.flutter.actions.DeviceSelectorRefresherAction"
text="Refresh Device List"
description="Refresh device list" />
description="Refresh device list"
icon="FlutterIcons.RefreshItems"/>
<add-to-group anchor="before" group-id="RunToolbarMainActionGroup" relative-to-action="RedesignedRunConfigurationSelector"/>
</group>

Expand Down Expand Up @@ -316,12 +317,14 @@
<separator/>
<!--suppress PluginXmlCapitalization -->
<action id="Flutter.Menu.RunProfileAction" class="io.flutter.actions.RunProfileFlutterApp"
description="Flutter Run Profile Mode"
description="Run Flutter app in profile mode"
text="Run in Flutter Profile Mode"
icon="AllIcons.Actions.Execute">
</action>
<!--suppress PluginXmlCapitalization -->
<action id="Flutter.Menu.RunReleaseAction" class="io.flutter.actions.RunReleaseFlutterApp"
description="Flutter Run Release Mode"
description="Run Flutter app in release mode"
text="Run in Flutter release mode"
icon="AllIcons.Actions.Execute">
</action>
<reference ref="AttachDebuggerAction"/>
Expand Down
9 changes: 6 additions & 3 deletions resources/META-INF/plugin_template.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
icon="FlutterIcons.Phone"/>
<action id="Flutter.DeviceSelectorRefresher" class="io.flutter.actions.DeviceSelectorRefresherAction"
text="Refresh Device List"
description="Refresh device list" />
description="Refresh device list"
icon="FlutterIcons.RefreshItems"/>
<add-to-group anchor="before" group-id="RunToolbarMainActionGroup" relative-to-action="RedesignedRunConfigurationSelector"/>
</group>

Expand Down Expand Up @@ -218,12 +219,14 @@
<separator/>
<!--suppress PluginXmlCapitalization -->
<action id="Flutter.Menu.RunProfileAction" class="io.flutter.actions.RunProfileFlutterApp"
description="Flutter Run Profile Mode"
description="Run Flutter app in profile mode"
text="Run in Flutter Profile Mode"
icon="AllIcons.Actions.Execute">
</action>
<!--suppress PluginXmlCapitalization -->
<action id="Flutter.Menu.RunReleaseAction" class="io.flutter.actions.RunReleaseFlutterApp"
description="Flutter Run Release Mode"
description="Run Flutter app in release mode"
text="Run in Flutter release mode"
icon="AllIcons.Actions.Execute">
</action>
<reference ref="AttachDebuggerAction"/>
Expand Down