Skip to content

[Impeller] Run Vulkan unit-tests by default. #112423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chinmaygarde opened this issue Sep 27, 2022 · 7 comments
Closed

[Impeller] Run Vulkan unit-tests by default. #112423

chinmaygarde opened this issue Sep 27, 2022 · 7 comments
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list
Milestone
Impeller on Android

Comments

@chinmaygarde
Copy link
Member

Currently, running the unit-tests requires the --enable-impeller-vulkan GN option enabled. Now that we have landed the Vulkan backend and are iterating on it in tree, perhaps it is time to remove the need for this flag.
@chinmaygarde
Copy link
Member Author

cc @iskakaushik WDYT?

@iskakaushik
Copy link
Contributor

Agreed. Is there a way to enable some tests but not all to start with? I'll see if there is a way to do this incrementally for Vulkan.

@iskakaushik iskakaushik self-assigned this Sep 27, 2022
@chinmaygarde chinmaygarde moved this from 🖖 Vulkan to ⚙️ In Progress in Impeller Sep 30, 2022
@chinmaygarde
Copy link
Member Author

@iskakaushik Are you still working on this? Feel free to unassign yourself if not. I can take a closer look at this too.

@iskakaushik
Copy link
Contributor

Yup. flutter/buildroot#639 was a prerequisite for this. Seems like you rolled buildroot in flutter/engine#36901. I will continue working on this.

@iskakaushik iskakaushik mentioned this issue Oct 24, 2022
Merged
@chinmaygarde
Copy link
Member Author

@iskakaushik Just catching up on old issues. Are there any blockers to doing this and removing the Vulkan opt-in on the host unit-tests?

@chinmaygarde chinmaygarde added this to the Impeller on Android milestone Dec 9, 2022
@chinmaygarde chinmaygarde moved this from ⚙️ In Progress to 🖖 Vulkan in Impeller Jan 11, 2023
@chinmaygarde
Copy link
Member Author

This is fixed.

@github-project-automation github-project-automation bot moved this from 🖖 Vulkan to ✅ Done in Impeller Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list
Projects
No open projects
Impeller
Archived in project
Milestone
Impeller on Android
Development

No branches or pull requests
2 participants
@chinmaygarde @iskakaushik