[Impeller] Add a shard for Impeller Vulkan testing #36965
Conversation
chinmaygarde
changed the title
|
cc @zanderso |
| @@ -1054,6 +1070,19 @@ def main(): | |||
| build_dir, engine_filter, args.coverage, args.engine_capture_core_dump | |||
| ) | |||
|
|
|||
| # Use this type to exclusively run impeller vulkan tests. | |||
There was a problem hiding this comment.
Since this looks like it will be temporary, is there a GitHub issue that can be commented here to track when we might be able to clean it up?
There was a problem hiding this comment.
done: filed flutter/flutter#113961 and added a ref in the comment
iskakaushik
force-pushed
the
impeller-vulkan-tests
branch
from
892c70e to
3244a32
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
iskakaushik
force-pushed
the
impeller-vulkan-tests
branch
from
bbec201 to
71fcb5b
Compare
iskakaushik
force-pushed
the
impeller-vulkan-tests
branch
from
cc78a3c to
829d734
Compare
testing/run_tests.py
Outdated
| # impeller vulkan tests are stable. | ||
| if 'impeller-vulkan' in types: | ||
| build_name = args.variant | ||
| xvfb.StartVirtualX(build_name, build_dir) |
There was a problem hiding this comment.
Consider making a contextmanager for this. Or at least put the Stop call in a finally.
iskakaushik
added
the
autosubmit
There are several passing and failing tests. To prevent regressions while the work on Vulkan is in-progress, I've setup a filter for the passing tests. Eventually this will be replaced to run all the tests.
Addresses: flutter/flutter#112423