Skip to content

Allow spell check to fail silently on unsupported platforms & for unsupported spell checkers #120611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
camsim99 opened this issue Feb 13, 2023 · 1 comment · Fixed by #122715
Closed

Allow spell check to fail silently on unsupported platforms & for unsupported spell checkers #120611

camsim99 opened this issue Feb 13, 2023 · 1 comment · Fixed by #122715
Assignees
@camsim99
Labels
a: text input Entering text in a text field or keyboard related problems c: proposal A detailed proposal for a change to Flutter framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list

Comments

@camsim99
Copy link
Contributor

camsim99 commented Feb 13, 2023 •
edited
Loading

Currently, if a SpellCheckConfiguration is defined to enable spell check (see docs) and the platform the app is running on does not have support for spell check (e.g. web) or the spell checker connected to the enabled IME on the device is not supported, an assertion error will be hit (see examples: #34688 (comment), #119868 (comment))

This should be modified to instead allow spell check to fail silently and a warning can be added to warn the developer that it is being disabled in order to avoid hitting the error.
@camsim99 camsim99 added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list labels Feb 13, 2023
This was referenced Feb 13, 2023
Closed
Closed
@camsim99 camsim99 added c: proposal A detailed proposal for a change to Flutter P3 Issues that are less important to the Flutter project P2 Important issues not at the top of the work list and removed P2 Important issues not at the top of the work list P3 Issues that are less important to the Flutter project labels Feb 13, 2023
@camsim99 camsim99 self-assigned this Feb 13, 2023
@camsim99 camsim99 mentioned this issue Mar 15, 2023
Merged
8 tasks
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@camsim99 camsim99

Labels
a: text input Entering text in a text field or keyboard related problems c: proposal A detailed proposal for a change to Flutter framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow spell check to fail silently on unsupported platforms & spell checkers camsim99/flutter
1 participant
@camsim99