-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Spellcheck for EditableText on iOS/Android #34688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Android also supports a spell checking service: https://developer.android.com/guide/topics/text/spell-checker-framework |
Any news on this issue? It would be ideal to be able to have this so that the applications are more similar to the native ones. |
Would anything prevent this from being a plugin? |
~If we want to use the stock spell checker on iOS (probably not going to be easy) we would have to make changes to the ios text plugin I think, as there doesn't seem to be a standalone spell checking api on iOS, it's most likely a feature we get from implementing Edit: there is |
Ahh, I see. Yeah, this sounds like something that belongs in the It actually doesn't sound like it'd be too terrible to implement - on iOS for example we should be able to just use an attributed string instead of a plain NSString, and then send annotations back to the framework as spelling corrections come in. I realize there's some async issues to tangle with there though :) |
This is a fundamental issue to any user of a flutter app. Literally my users are telling me they don't want to use my flutter-based messaging app dara.network because they end up sending out misspellings to those they are attempting to impress. It's literally hurting their social credibility. Please, please, please fix this. |
Bumping to P3 – per @jenle-g – this feels like a big hole VS native platforms and the web. |
+1 |
@LongCatIsLooong are you working or planning to work on this issue? |
Any updates for it? |
Hi @camsim99, |
@mohamedali170 Android and iOS both have partial implementation. Implementation of the red underline and the toolbar with suggestions for Android and iOS is expected around EOY. I'll update this issue when more pieces of the implementation land! |
Well, thanks very much for your efforts @camsim99 . I hope you can finish the remaining implementation in the near future. |
Just wanted to update here that I have merged the remaining implementation on Android into the |
Nice! Do you have an idea which version this might land in? |
It appears this feature has landed in Flutter 3.7. To use it, add this parameter to your EditableText or TextField: spellCheckConfiguration: kIsWeb ? null : SpellCheckConfiguration() (The spell check configuration currently seems to break on web) |
Good progress! Sad news about web though. Hopefully we won't have to wait until another point release for it. |
@jonbhanson yes, spell check is partially implemented on both! Thank you for pointing out the crash on web. Filed an issue to follow up on better solutions for crashing in that case #119542 |
This comment was marked as duplicate.
This comment was marked as duplicate.
Closing this since it's now complete for iOS and Android as of 3.10 |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Related Issue: #12920 autocorrection
Related UIKit documentation: https://developer.apple.com/documentation/uikit/uitextinputtraits/1624461-spellcheckingtype
The text was updated successfully, but these errors were encountered: