Skip to content

Combine clipping rect iOS scenario test goldens to reduce maintenance burden keeping them updated #154754

Open
@jmagman

Description

@jmagman

The iOS scenario screenshots are a maintenance burden (see their update instruction) to keep updated, and are checked into the engine repo. I'm hitting this pain now turning on more tests for impeller, but they also have to be updated every time we do a major iOS update.

flutter/engine#54820 created 12 new clipping test golden screenshots. Can the new multiclip goldens be removed, and instead added as a new shape to the existing clip screenshots? For example, the new shape is right under the old shape? For example, this screenshot is testing multiple images at the same time:

cc @hellohuanlin

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: tech-debtTechnical debt, code quality, testing, etc.engineflutter/engine repository. See also e: labels.team-iosOwned by iOS platform teamtriaged-iosTriaged by iOS platform team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions