exception when downloading artifacts, and should introduce a timeout on download

[umop]

flutter doctor "exited unexpectedly" on first run.

Last words:

Downloading engine artifacts android-arm...   47.9s
Downloading engine artifacts android-x64...      /

Oops; flutter has exited unexpectedly.
Crash report written to flutter_01.log; please let us know at https://github.com/flutter/flutter/issues.

flutter_01.log showed a timeout (and engine artifacts android-arm took a while as well). Internet connection was slow, but stable.

Second try succeeded in that portion:
Downloading engine artifacts android-arm...   2.9s
Downloading engine artifacts android-x64...   3.6s

but when I came back to the terminal window about two weeks later, the process was still running:

ericarnold-macbookpro:~ ericarnold$ flutter doctor
Downloading engine package sky_engine...      1.2s
Downloading engine package sky_services...    0.6s
Downloading engine artifacts android-arm...   3.0s
Downloading engine artifacts android-x64...      / <-- baton is still spinning after ~2 weeks

[devoncarew]

Could you attach the first bit of the stack trace? We want to catch places where we throw exceptions; we should instead display an error to the user.

[umop]

Here's a chunk:

SocketException: OS Error: Operation timed out, errno = 60, address = storage.googleapis.com, port = 57291

dart:io                                                           _HttpClient.getUrl
package:flutter_tools/src/cache.dart 104                          Cache._downloadFile.<async>
===== asynchronous gap ===========================
dart:async                                                        Future.Future.microtask
package:flutter_tools/src/cache.dart                              Cache._downloadFile
package:flutter_tools/src/cache.dart 125                          Cache._downloadFileToCache.<async>
===== asynchronous gap ===========================
dart:async                                                        Future.Future.microtask
package:flutter_tools/src/cache.dart                              Cache._downloadFileToCache
package:flutter_tools/src/cache.dart 248                          FlutterEngine._downloadItem
package:flutter_tools/src/cache.dart 227                          FlutterEngine.download.<async>
dart:async                                                        _SyncCompleter.complete
package:flutter_tools/src/cache.dart 138                          Cache._downloadFileToCache.<async>
dart:async                                                        _SyncCompleter.complete
package:flutter_tools/src/cache.dart 115                          Cache._downloadFile.<async>

[devoncarew]

Thanks!

<-- baton is still spinning after ~2 weeks

And, good to know that the spinner code at least is rock solid!

[Hixie]

This will now retry on failure, but I don't know how we can detect that the network is broken vs the network being really slow, so the two-week thing isn't really something I know how to fix. A timeout doesn't help, if we set a 1 week timeout, what about people who need 8 days to download it?

Closing because the specific crash has been fixed since.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.