Skip to content

Expose BinaryMessenger from FlutterEngine in Windows API #62871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stuartmorgan-g opened this issue Aug 4, 2020 · 1 comment · Fixed by flutter/engine#20399 or flutter/engine#20551
Closed
Assignees
Labels
a: desktop Running on desktop engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list

Comments

@stuartmorgan-g
Copy link
Contributor

Currently the only way to get a BinaryMessenger is as a plugin. Adding an engine->messenger getter to the C API is simple, but the C++ wrapper will need to be extracted from plugin_registrar.cc so that it can be re-used.

@stuartmorgan-g stuartmorgan-g self-assigned this Aug 4, 2020
@stuartmorgan-g stuartmorgan-g added a: desktop Running on desktop engine flutter/engine repository. See also e: labels. labels Aug 4, 2020
@stuartmorgan-g stuartmorgan-g added this to the 1.22 - August 2020 milestone Aug 4, 2020
@gspencergoog gspencergoog added the P2 Important issues not at the top of the work list label Aug 12, 2020
stuartmorgan-g added a commit to flutter/engine that referenced this issue Aug 16, 2020
Makes BinaryMessenger available from FlutterEngine, rather than just the plugin registrar. This allows for method channels directly in applications without building them as plugins, and matches the other platforms.

Requires some restructuring of code and GN targets in the client wrappers to make the internals in the shared section usable by the implementations of platform-specific parts of the wrappers. Also fixes a latent issue with EnableInputBlocking symbols being declared but not defined for Windows that came up during testing of the restructuring.

Fixes flutter/flutter#62871
stuartmorgan-g added a commit to flutter/engine that referenced this issue Aug 17, 2020
Relands #20399

Makes BinaryMessenger available from FlutterEngine, rather than just the plugin registrar. This allows for method channels directly in applications without building them as plugins, and matches the other platforms.

Requires some restructuring of code and GN targets in the client wrappers to make the internals in the shared section usable by the implementations of platform-specific parts of the wrappers. Also fixes a latent issue with EnableInputBlocking symbols being declared but not defined for Windows that came up during testing of the restructing.

Fixes flutter/flutter#62871
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: desktop Running on desktop engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list
Projects
None yet
2 participants