CupertinoNavigationBar part 2 - create a bare bone CupertinoNavigationBar #10423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xster
changed the title
Hixie
reviewed
Jun 1, 2017
| /// Tab changes typically trigger a switch between [Navigator]s, each with its | ||
| /// own navigation stack, per standard iOS design. | ||
| /// | ||
| /// If the given [backgroundColor] is translucent, it will produce a blurring |
There was a problem hiding this comment.
the color can only be semi-transparent, not translucent. I would just say "If the given [backgroundColor] has an opacity less than 1.0 (which is the case for the default value)..."
There was a problem hiding this comment.
umm true. English fail. Corrected.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7508
Not in this PR: a CupertinoBack/CancelButton which needs #10334 solved first
Diffbases: #10337