fix a _ScaffoldLayout delegate update bug #104954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
xu-baolin
commented
May 30, 2022
| @@ -276,12 +276,17 @@ void main() { | |||
| await tester.pumpWidget( | |||
| MediaQuery( | |||
| data: const MediaQueryData( | |||
| padding: EdgeInsets.only(bottom: 20.0), | |||
| viewPadding: EdgeInsets.only(bottom: 20.0), | |||
There was a problem hiding this comment.
Currently, the Floating Action Button's position has nothing to do with padding.bottom.
Maybe a typo? CC @Piinks : )
There was a problem hiding this comment.
Likely the case, IIRC this was a big change with a lot of code re-use between tests. Copy paste issue is my guess. 😝
xu-baolin
commented
May 30, 2022
| tester.getBottomLeft(find.byType(Placeholder)).dy, | ||
| moreOrLessEquals(600.0 - 20.0 - kFloatingActionButtonMargin) | ||
| ); | ||
|
|
||
| // Consume bottom padding - as if by the keyboard opening | ||
| await tester.pumpWidget( |
There was a problem hiding this comment.
Before this change, this does not trigger a re-layout, so the test passes.
This was referenced May 30, 2022
Piinks
approved these changes
Jun 7, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jun 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 8, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #60248 (comment)
Found this issue when landing #104958
That change will wrap a
LayoutBuilderwidget to the body widget and add a dependence with mediaQueryData.When
Floating Action Button bottom padding not consumed by viewInsetschange the media data will cause the upperre-layout boundary dirty and trigger the _ScaffoldLayout re-layout, then the test failed.
So interesting.