-
Notifications
You must be signed in to change notification settings - Fork 28.5k
Remove exclamation marks #107683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove exclamation marks #107683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for cleaning this up!
@LongCatIsLooong @justinmc Is there a plan to hotfix this into the stable branch? Many users are facing this issue. |
@limenote135 What is the issue exactly? I want to make sure I understand which of the changes in this PR are unblocking you and in what way. |
Perfect, thank you! @itsjustkevin Are we able to cherry-pick this fix? |
@justinmc @itsjustkevin hi, how is it going? |
Hi I am experiencing issue which this PR is supposed to fix. When will this come to stable branch? Null check operator used on a null value. |
@DjordjeMancic97 from the stacktrace this is not the same issue. It may have to do with the platform menu system. Could you open a new issue if there isn't one? For those on the stable branch, the diff is one line: https://github.com/flutter/flutter/pull/107683/files#diff-f5f93c879cef9a102adbf148583de9f3d9a05f9678fdcad7bde106f62200bb34 so it's an option to patch this locally for the time being. |
Co-authored-by: LongCatIsLooong <[email protected]> Co-authored-by: Casey Hillers <[email protected]>
Remove some unnecessary
!
s in input decorator.Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.