Skip to content

Deletes files that should be ignored #127984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 29, 2023
Merged

Deletes files that should be ignored #127984

merged 6 commits into from
Jun 29, 2023

Conversation

lsaudon
Copy link
Contributor

@lsaudon lsaudon commented May 31, 2023

Some files are supposed to ignore, but don't.

  • **/windows/flutter/generated_plugins.cmake
  • **/linux/flutter/generated_plugin_registrant.cc
  • **/linux/flutter/generated_plugin_registrant.h
  • **/linux/flutter/generated_plugins.cmake
  • **/windows/flutter/generated_plugin_registrant.cc
  • **/windows/flutter/generated_plugin_registrant.h
  • **/ios/Runner/GeneratedPluginRegistrant.h
  • **/ios/Runner/GeneratedPluginRegistrant.m

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 31, 2023
@github-actions github-actions bot removed the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 31, 2023
@goderbauer goderbauer added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 1, 2023
@loic-sharma loic-sharma self-requested a review June 22, 2023 17:22
@loic-sharma loic-sharma added the a: desktop Running on desktop label Jun 22, 2023
@loic-sharma
Copy link
Member

loic-sharma commented Jun 23, 2023 •
edited
Loading

Thanks for the contribution!

For background history on this, see this comment: #119544 (comment)

TLDR:

  1. Flutter repo added .gitignore for these files as a workaround
  2. Proper fix would be to move these files to the runners' ephemeral directory, which is ignored by git
  3. Regardless, these files shouldn't be checked-in :)

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 23, 2023

auto label is removed for flutter/flutter, pr: 127984, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

yaakovschectman
yaakovschectman approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@yaakovschectman yaakovschectman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have been a bit annoying in some of my work before, too. LGTM

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 27, 2023

auto label is removed for flutter/flutter, pr: 127984, due to - The status or check suite triage has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 27, 2023
@lsaudon
Copy link
Contributor Author

lsaudon commented Jun 27, 2023

auto label is removed for flutter/flutter, pr: 127984, due to - The status or check suite triage has failed. Please fix the issues identified (or deflake) before re-applying this label.

I don't understand the error in Pull Request Labeler / triage (pull_request_target)

@loic-sharma
Copy link
Member

auto label is removed for flutter/flutter, pr: 127984, due to - The status or check suite triage has failed. Please fix the issues identified (or deflake) before re-applying this label.

I don't understand the error in Pull Request Labeler / triage (pull_request_target)

This appears to be an infra bug that's unrelated to your change, see this discussion: https://discord.com/channels/608014603317936148/613398423093116959/1123366240153501817

@github-actions github-actions bot removed the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 27, 2023
@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2023
@auto-submit auto-submit bot merged commit 7cab354 into flutter:master Jun 29, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2023
@engine-flutter-autoroll
7cab354 Deletes files that should be ignored (flutter/flutter#127984)
9070f30
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 1, 2023
@engine-flutter-autoroll
Roll Flutter from ff838bc to aa5f4a2 (29 revisions) (#4363)
cdae854 
flutter/flutter@ff838bc...aa5f4a2

2023-07-01 [email protected] Enable no_wildcard_variable_uses lint (flutter/flutter#129858)
2023-06-30 [email protected] mark packages-autoroller bringup again (flutter/flutter#129859)
2023-06-30 [email protected] Update `SwitchTheme` tests for M2/M3 (flutter/flutter#129811)
2023-06-30 [email protected] Change pub roller bot to push to flutter-pub-roller-bot/flutter.git (flutter/flutter#129844)
2023-06-30 [email protected] Fix NetworkImage causing spurious warning in tests (flutter/flutter#129537)
2023-06-30 [email protected] Roll Flutter Engine from 54b573e9c4e5 to e6b8292705a8 (4 revisions) (flutter/flutter#129852)
2023-06-30 [email protected] Upgrade integration tests to use AGP 7.3/Gradle 7.4 (flutter/flutter#129642)
2023-06-30 [email protected] Roll Packages from d4752c4 to 53ed5a0 (5 revisions) (flutter/flutter#129837)
2023-06-30 [email protected] Updated correct tasks for test ownership fix (flutter/flutter#129812)
2023-06-30 [email protected] Updated some golden image tests for M2/M3 (flutter/flutter#129794)
2023-06-30 [email protected] Remove an unnecessary assert (flutter/flutter#129796)
2023-06-30 [email protected] Update `Radio` tests for M2/M3 (flutter/flutter#129814)
2023-06-30 [email protected] Update `Switch` tests for M2/M3 (flutter/flutter#129810)
2023-06-30 [email protected] Roll Flutter Engine from 099a70ebbc60 to 54b573e9c4e5 (1 revision) (flutter/flutter#129821)
2023-06-30 [email protected] Update `SwitchListTile` tests for M2/M3 (flutter/flutter#129809)
2023-06-30 [email protected] Fix `NavigationDrawer` selected item has wrong icon color (flutter/flutter#129625)
2023-06-30 [email protected] Update basic_test.dart for M3 compliance (flutter/flutter#129714)
2023-06-30 [email protected] Roll Flutter Engine from d33343430f18 to 099a70ebbc60 (7 revisions) (flutter/flutter#129818)
2023-06-30 [email protected] Roll Flutter Engine from 68cc1a7971d5 to d33343430f18 (2 revisions) (flutter/flutter#129801)
2023-06-30 [email protected] Revert no-response to fork. (flutter/flutter#129775)
2023-06-30 [email protected] Make `DropdownMenu` be able to scroll to the highlighted item when searching. (flutter/flutter#129740)
2023-06-29 [email protected] Roll Flutter Engine from cd9ce66db14a to 68cc1a7971d5 (10 revisions) (flutter/flutter#129799)
2023-06-29 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.1.0 to 4.2.0 (flutter/flutter#129797)
2023-06-29 [email protected] Roll Flutter Engine from eabb22900b44 to cd9ce66db14a (1 revision) (flutter/flutter#129756)
2023-06-29 [email protected] Remove `@NonNull` to avoid warning (flutter/flutter#129472)
2023-06-29 [email protected] Remove use of any (flutter/flutter#129793)
2023-06-29 [email protected] Prepare for utf8.encode() to return more precise Uint8List type (flutter/flutter#129769)
2023-06-29 [email protected] Deletes files that should be ignored (flutter/flutter#127984)
2023-06-29 [email protected] Fix flutter_plugins by rolling revision (flutter/flutter#129781)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
7cab354 Deletes files that should be ignored (flutter/flutter#127984)
c8d5e7e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
7cab354 Deletes files that should be ignored (flutter/flutter#127984)
48f82ef
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
7cab354 Deletes files that should be ignored (flutter/flutter#127984)
6b18551
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
7cab354 Deletes files that should be ignored (flutter/flutter#127984)
3eb3720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@yaakovschectman yaakovschectman yaakovschectman approved these changes

@cbracken cbracken Awaiting requested review from cbracken

Assignees
No one assigned
Labels
a: desktop Running on desktop autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsaudon @loic-sharma @yaakovschectman @goderbauer