[Windows] Allow overwriting the cache's Dart SDK archive license file #132669

loic-sharma · 2023-08-16T17:09:55Z

flutter/engine#43974 added a license file to the Dart SDK's ZIP archive which gets extracted to flutter/bin/cache/LICENSE.dart_sdk_archive.md. As a result, extracting the Dart SDK now needs to update the cache's LICENSE.dart_sdk_archive.md file.

Windows ZIP extraction does not enable overwriting files. Thus, this change renames the cache's existing Dart SDK license file before extracting the Dart SDK archive.

This is a short-term solution that will be cherry-picked for the next 3.14 beta release. Addresses #132592.

The long-term solution is tracked by #132702

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hixie · 2023-08-16T19:45:34Z

would it be more resilient to future changes if we had a more general way of doing this rather than needing to know the exactly list of files we were expecting?

packages/flutter_tools/test/integration.shard/batch_entrypoint_test.dart

loic-sharma · 2023-08-17T00:14:59Z

would it be more resilient to future changes if we had a more general way of doing this rather than needing to know the exactly list of files we were expecting?

Summary of this Discord conversation: This fix is time sensitive as it unblocks the 3.14 beta release. A more robust solution is tracked by #132702.

christopherfujino

LGTM

…flutter#132669) flutter/engine#43974 added a license file to the Dart SDK's ZIP archive. As a result, extracting the Dart SDK now needs to overwrite the cache's `LICENSE.dart_sdk_archive.md` file. This is a short-term solution that will be cherry-picked for the next [3.14 beta release](flutter#132267). Addresses flutter#132592. The long-term solution is tracked by flutter#132702

yaakovschectman · 2023-08-17T17:23:45Z

This is introducing test failures for the windows, linux, and mac framework_test_libraries on the tree build.

…nse file (#132669)" This reverts commit 7ee864e.

…nse file" (#132773) Reverts #132669 Introduced failure on `windows/mac/linux framework_library_tests`. ``` 05:41 +7318 ~22 -1: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_bar_theme_test.dart: (tearDownAll) [E] Expected: leak free Actual: <Instance of 'Leaks'> Which: contains leaks: # The text is generated by leak_tracker. # For leak troubleshooting tips open: # https://github.com/dart-lang/leak_tracker/blob/main/doc/TROUBLESHOOT.md notDisposed: total: 3 objects: ValueNotifier<_OverlayEntryWidgetState?>: test: Constructor parameters override theme parameters identityHashCode: 407433615 FocusScopeNode: test: Constructor parameters override theme parameters identityHashCode: 513181650 FocusScopeNode: test: Constructor parameters override theme parameters identityHashCode: 704743556 package:matcher expect package:flutter_test/src/widget_tester.dart 458:18 expect package:leak_tracker_flutter_testing/src/leak_tracking_flutter_testing.dart 81:5 _tearDownTestingWithLeakTracking ===== asynchronous gap =========================== dart:async _CustomZone.registerBinaryCallback package:leak_tracker_flutter_testing/src/leak_tracking_flutter_testing.dart 59:9 configureLeakTrackingTearDown.<fn> ```

… file (#132762) Original pull request: #132669 Cherrypick issue: #132718

…flutter#132669) flutter/engine#43974 added a license file to the Dart SDK's ZIP archive. As a result, extracting the Dart SDK now needs to overwrite the cache's `LICENSE.dart_sdk_archive.md` file. This is a short-term solution that will be cherry-picked for the next [3.14 beta release](flutter#132267). Addresses flutter#132592. The long-term solution is tracked by flutter#132702

#132777) Relands #132669 after it was reverted by #132773. The test failures were fixed separately by #132766 Tracking issue: #132592 Cherrypick issue: #132718

…nse file (flutter/flutter#132669)

Update the Dart SDK archive's license file

7f85377

Integration test

5c31311

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 16, 2023

loic-sharma added 2 commits August 16, 2023 15:58

Tweak

e130d62

Tweak

9a12279

christopherfujino reviewed Aug 16, 2023

View reviewed changes

packages/flutter_tools/test/integration.shard/batch_entrypoint_test.dart Outdated Show resolved Hide resolved

christopherfujino reviewed Aug 16, 2023

View reviewed changes

packages/flutter_tools/test/integration.shard/batch_entrypoint_test.dart Outdated Show resolved Hide resolved

christopherfujino reviewed Aug 16, 2023

View reviewed changes

packages/flutter_tools/test/integration.shard/batch_entrypoint_test.dart Outdated Show resolved Hide resolved

loic-sharma added 4 commits August 16, 2023 16:59

Polish

56055c4

Feedback

f1a60a2

Fix

56bdec9

Yay compilers

e1d2032

loic-sharma marked this pull request as ready for review August 17, 2023 00:09

loic-sharma requested review from cbracken and yaakovschectman August 17, 2023 00:09

loic-sharma added the platform-windows Building on or for Windows specifically label Aug 17, 2023

loic-sharma added 3 commits August 16, 2023 17:17

Format

e4ca3c7

Tweaks

324f468

Tweak

1011f17

christopherfujino approved these changes Aug 17, 2023

View reviewed changes

Format

771da48

christopherfujino mentioned this pull request Aug 17, 2023

[CP] Fix Windows powershell script not being able to update Dart SDK #132718

Closed

yaakovschectman approved these changes Aug 17, 2023

View reviewed changes

loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2023

auto-submit bot merged commit 7ee864e into flutter:master Aug 17, 2023

loic-sharma deleted the windows_update_hang branch August 17, 2023 16:23

loic-sharma mentioned this pull request Aug 17, 2023

[CP] [Windows] Allow overwriting the cache's Dart SDK archive license file #132762

Merged

8 tasks

yaakovschectman added a commit that referenced this pull request Aug 17, 2023

Revert "[Windows] Allow overwriting the cache's Dart SDK archive lice…

49a95af

…nse file (#132669)" This reverts commit 7ee864e.

yaakovschectman mentioned this pull request Aug 17, 2023

Revert "[Windows] Allow overwriting the cache's Dart SDK archive license file" #132773

Merged

auto-submit bot pushed a commit that referenced this pull request Aug 17, 2023

[CP] [Windows] Allow overwriting the cache's Dart SDK archive license…

a62bb1f

… file (#132762) Original pull request: #132669 Cherrypick issue: #132718

christopherfujino mentioned this pull request Aug 17, 2023

[Windows] Allow overwriting the cache's Dart SDK archive license file - second attempt #132776

Closed

loic-sharma mentioned this pull request Aug 17, 2023

[Windows] Allow overwriting the cache's Dart SDK archive license file… #132777

Merged

8 tasks

engine-flutter-autoroll mentioned this pull request Aug 17, 2023

Roll Flutter from 2502b51f86c1 to 9e67e0e4a13b (24 revisions) flutter/packages#4732

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

7ee864e [Windows] Allow overwriting the cache's Dart SDK archive lice…

94dfab1

…nse file (flutter/flutter#132669)

engine-flutter-autoroll mentioned this pull request Aug 18, 2023

Roll Flutter from 2502b51f86c1 to 633b1ce402c7 (39 revisions) flutter/packages#4740

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023

7ee864e [Windows] Allow overwriting the cache's Dart SDK archive lice…

593b71d

…nse file (flutter/flutter#132669)

engine-flutter-autoroll mentioned this pull request Aug 18, 2023

Roll Flutter from 2502b51f86c1 to 312ef541156c (40 revisions) flutter/packages#4741

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023

7ee864e [Windows] Allow overwriting the cache's Dart SDK archive lice…

435571b

…nse file (flutter/flutter#132669)

engine-flutter-autoroll mentioned this pull request Aug 18, 2023

Roll Flutter from 2502b51f86c1 to b52297da0620 (41 revisions) flutter/packages#4742

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023

7ee864e [Windows] Allow overwriting the cache's Dart SDK archive lice…

0582f7b

…nse file (flutter/flutter#132669)

engine-flutter-autoroll mentioned this pull request Aug 18, 2023

Roll Flutter from 2502b51f86c1 to 5a556f8ecde6 (42 revisions) flutter/packages#4743

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023

7ee864e [Windows] Allow overwriting the cache's Dart SDK archive lice…

fbb45f2

…nse file (flutter/flutter#132669)

HansMuller mentioned this pull request Aug 25, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

7ee864e [Windows] Allow overwriting the cache's Dart SDK archive lice…

e61d1a9

…nse file (flutter/flutter#132669)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Windows] Allow overwriting the cache's Dart SDK archive license file #132669

[Windows] Allow overwriting the cache's Dart SDK archive license file #132669

Uh oh!

loic-sharma commented Aug 16, 2023 •

edited

Loading

Uh oh!

Hixie commented Aug 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

loic-sharma commented Aug 17, 2023

Uh oh!

christopherfujino left a comment

Uh oh!

yaakovschectman commented Aug 17, 2023

Uh oh!

Uh oh!

[Windows] Allow overwriting the cache's Dart SDK archive license file #132669

[Windows] Allow overwriting the cache's Dart SDK archive license file #132669

Uh oh!

Conversation

loic-sharma commented Aug 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Hixie commented Aug 16, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

loic-sharma commented Aug 17, 2023

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

yaakovschectman commented Aug 17, 2023

Uh oh!

Uh oh!

loic-sharma commented Aug 16, 2023 •

edited

Loading