Skip to content

Conversation

godofredoc
Copy link
Contributor

This is to prevent failures when the gsutil.py is not executable.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This is to prevent failures when the gsutil.py is not executable.
Copy link
Contributor

@drewroengoogle drewroengoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

return _processRunner.runProcess(
<String>['gsutil.py', '--', ...args],
<String>['python3', path.join(platform.environment['DEPOT_TOOLS']!, 'gsutil.py'), '--', ...args],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so DEPOT_TOOLS env var is set on linux and mac, right? previously we were relying on it being on path

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, lgtm

@christopherfujino
Copy link
Contributor

Looks like unit tests are failing:

00:25 +30 ~1 -5: test/prepare_package_test.dart: ArchivePublisher for linux updates base_url from old bucket to new bucket [E]                                                                         
  Expected: [
              'gsutil.py',
              '--',
              'cp',
              'gs://flutter_infra_release/releases/releases_linux.json',
              '/b/s/w/ir/x/t/flutter_prepage_package_test.WXVRYT/releases_linux.json'
            ]
    Actual: [
              'python3',
              'D:/depot_tools/gsutil.py',
              '--',
              'cp',
              'gs://flutter_infra_release/releases/releases_linux.json',
              '/b/s/w/ir/x/t/flutter_prepage_package_test.WXVRYT/releases_linux.json'
            ]
     Which: at location [0] is 'python3' instead of 'gsutil.py'

@christopherfujino
Copy link
Contributor

Windows framework_tests_libraries looks like a goldens flake

@godofredoc
Copy link
Contributor Author

Looks like unit tests are failing:

00:25 +30 ~1 -5: test/prepare_package_test.dart: ArchivePublisher for linux updates base_url from old bucket to new bucket [E]                                                                         
  Expected: [
              'gsutil.py',
              '--',
              'cp',
              'gs://flutter_infra_release/releases/releases_linux.json',
              '/b/s/w/ir/x/t/flutter_prepage_package_test.WXVRYT/releases_linux.json'
            ]
    Actual: [
              'python3',
              'D:/depot_tools/gsutil.py',
              '--',
              'cp',
              'gs://flutter_infra_release/releases/releases_linux.json',
              '/b/s/w/ir/x/t/flutter_prepage_package_test.WXVRYT/releases_linux.json'
            ]
     Which: at location [0] is 'python3' instead of 'gsutil.py'

Updated the tests.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

return _processRunner.runProcess(
<String>['gsutil.py', '--', ...args],
<String>['python3', path.join(platform.environment['DEPOT_TOOLS']!, 'gsutil.py'), '--', ...args],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, lgtm

@godofredoc godofredoc added autosubmit Merge PR when tree becomes green via auto submit App warning: land on red to fix tree breakage labels Aug 17, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 17, 2023

auto label is removed for flutter/flutter/132805, due to - The status or check suite Linux web_long_running_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2023
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2023
@auto-submit auto-submit bot merged commit a70a852 into flutter:master Aug 17, 2023
@godofredoc godofredoc deleted the fix_packaging branch August 17, 2023 23:09
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants