-
Notifications
You must be signed in to change notification settings - Fork 29.2k
Run gsutil with full python3 and full path. #132805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is to prevent failures when the gsutil.py is not executable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
return _processRunner.runProcess( | ||
<String>['gsutil.py', '--', ...args], | ||
<String>['python3', path.join(platform.environment['DEPOT_TOOLS']!, 'gsutil.py'), '--', ...args], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so DEPOT_TOOLS env var is set on linux and mac, right? previously we were relying on it being on path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, lgtm
Looks like unit tests are failing:
|
|
Updated the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
return _processRunner.runProcess( | ||
<String>['gsutil.py', '--', ...args], | ||
<String>['python3', path.join(platform.environment['DEPOT_TOOLS']!, 'gsutil.py'), '--', ...args], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, lgtm
auto label is removed for flutter/flutter/132805, due to - The status or check suite Linux web_long_running_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This is to prevent failures when the gsutil.py is not executable.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.