Skip to content

_ResetNotifier should communicate creation in constructor. #133716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2023
Merged

_ResetNotifier should communicate creation in constructor. #133716

merged 2 commits into from
Aug 31, 2023

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Aug 30, 2023 •
edited
Loading

No testing because the classes are private and the change impacts just debugging UX.
see Discord message

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Aug 30, 2023
@polina-c polina-c marked this pull request as ready for review August 31, 2023 13:52
@polina-c polina-c changed the title _ResetNotifier _ResetNotifier should communicate creation in constructor. Aug 31, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@polina-c polina-c requested a review from Hixie August 31, 2023 14:00
@polina-c polina-c mentioned this pull request Aug 31, 2023
Closed
@Hixie
Copy link
Contributor

Hixie commented Aug 31, 2023

test-exempt: preparing for future testing

@polina-c polina-c requested review from chunhtai and removed request for Hixie August 31, 2023 16:44
chunhtai
chunhtai approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c merged commit 54402ae into flutter:master Aug 31, 2023
@polina-c polina-c deleted the _ResetNotifier branch August 31, 2023 17:18
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
8038e20 
…lutter/flutter#133716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
83f34a4 
…lutter/flutter#133716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
37a5cba 
…lutter/flutter#133716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
00a0caa 
…lutter/flutter#133716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
510b2df 
…lutter/flutter#133716)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
be21cdf 
…lutter/flutter#133716)
@HansMuller HansMuller mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
3643c86 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
1c87e52 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
a5ecbf6 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
cd11223 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
d68156e 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
a61c34c 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
66732a5 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
f153c52 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
be47d80 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
891deb8 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
dd02315 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
fce7951 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
669b1fa 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
362cdb4 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
9bbdf67 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
c8ea47a 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
61b957e 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
c964ff8 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
d91e90e 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
8129c9b 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
6e53189 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
7ff3f41 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
55489a5 
…lutter/flutter#133716)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
54402ae _ResetNotifier should communicate creation in constructor. (f…
855ecc9 
…lutter/flutter#133716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polina-c @Hixie @chunhtai