Skip to content

Manual roll of engine #134595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2023
Merged

Manual roll of engine #134595

merged 2 commits into from
Sep 13, 2023

Conversation

itsjustkevin
Copy link
Contributor

reverts flutter/engine#45747 to unblock the flutter roll.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: focus Focus traversal, gaining or losing focus labels Sep 13, 2023
@itsjustkevin itsjustkevin reopened this Sep 13, 2023
@itsjustkevin itsjustkevin changed the base branch from master to flutter-3.14-candidate.15 September 13, 2023 01:00
zanderso
zanderso approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the engine artifacts hadn't finished building yet.

@itsjustkevin itsjustkevin merged commit 6dbc681 into flutter:flutter-3.14-candidate.15 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
engine flutter/engine related. See also e: labels. f: focus Focus traversal, gaining or losing focus f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsjustkevin @zanderso