Skip to content

Update Android app project template to apply Kotlin Gradle plugin declaratively #139006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 27, 2023
Merged

Update Android app project template to apply Kotlin Gradle plugin declaratively #139006

merged 4 commits into from
Nov 27, 2023

Conversation

bartekpacia
Copy link
Member

This PR updates the app templates generated by flutter create to use declarative plugins {} syntax for applying the Kotlin Gradle Plugin.

I realized this is missing while writing #9857.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 25, 2023
@bartekpacia bartekpacia mentioned this pull request Nov 25, 2023
Merged
3 tasks
@bartekpacia bartekpacia added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 27, 2023
@auto-submit auto-submit bot merged commit e8282ed into flutter:master Nov 27, 2023
@bartekpacia bartekpacia deleted the chore/declarative_kotlin_apply branch November 27, 2023 21:19
@bartekpacia
Copy link
Member Author

bartekpacia commented Nov 27, 2023 •
edited
Loading

cc @christopherfujino - you might want to take a look as well. I probably should've added you to review since you work on the tool, but I forgot - sorry.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 27, 2023
@engine-flutter-autoroll
e8282ed Update Android app project template to apply Kotlin Gradle pl…
441daec 
…ugin declaratively (flutter/flutter#139006)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 28, 2023
@engine-flutter-autoroll
Manual roll Flutter from b5f163a to 6bf3ccd (20 revisions) (#5495)
3c05466 
Manual roll requested by [email protected]

flutter/flutter@b5f163a...6bf3ccd

2023-11-27 [email protected] [flutter_tools] fix instructions to disable CLI animations (flutter/flutter#139094)
2023-11-27 [email protected] Roll Flutter Engine from 9fe149249957 to 900ce09b08b2 (3 revisions) (flutter/flutter#139095)
2023-11-27 [email protected] Wide gamut and platform view integration test. (flutter/flutter#138837)
2023-11-27 [email protected] Add ability to customize `NavigationBar` indicator overlay and fix indicator shape for the overlay (flutter/flutter#138901)
2023-11-27 [email protected] Roll Flutter Engine from cc57ace8e2e7 to 9fe149249957 (1 revision) (flutter/flutter#139077)
2023-11-27 [email protected] Add type validation to non-template .arb file parsing logic (flutter/flutter#139035)
2023-11-27 [email protected] Update Android app project template to apply Kotlin Gradle plugin declaratively (flutter/flutter#139006)
2023-11-27 [email protected] Prepare for dynamically sized views - pt. 2 (flutter/flutter#139079)
2023-11-27 [email protected] Prepare for dynamically sized views (flutter/flutter#138565)
2023-11-27 [email protected] Write tests for API examples of BottomNavigationBar and IconButton (flutter/flutter#138188)
2023-11-27 [email protected] Roll Flutter Engine from 9b610ecda771 to cc57ace8e2e7 (2 revisions) (flutter/flutter#139072)
2023-11-27 [email protected] Give an actionable error message when a Pod requires a higher minimum OS version (flutter/flutter#138097)
2023-11-27 [email protected] Edge case on flutter/flutter/issues/135402 with test (flutter/flutter#138814)
2023-11-27 [email protected] Roll Packages from 97f0a40 to e774e88 (4 revisions) (flutter/flutter#139066)
2023-11-27 [email protected] Roll Flutter Engine from 6f499ecea657 to 9b610ecda771 (1 revision) (flutter/flutter#139063)
2023-11-27 [email protected] Roll Flutter Engine from 61233cde4bb3 to 6f499ecea657 (2 revisions) (flutter/flutter#139051)
2023-11-27 [email protected] Roll Flutter Engine from 292a92166a94 to 61233cde4bb3 (1 revision) (flutter/flutter#139041)
2023-11-27 [email protected] Roll Flutter Engine from ebebb25aaa46 to 292a92166a94 (3 revisions) (flutter/flutter#139037)
2023-11-27 [email protected] Roll Flutter Engine from eb18add9ebc5 to ebebb25aaa46 (2 revisions) (flutter/flutter#139034)
2023-11-26 [email protected] Roll Flutter Engine from 77432202f766 to eb18add9ebc5 (1 revision) (flutter/flutter#139007)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
@bartekpacia @caseycrogers
Update Android app project template to apply Kotlin Gradle plugin dec…
cdb0fa7 
…laratively (flutter#139006)

This PR updates the app templates generated by `flutter create` to use declarative `plugins {}` syntax for applying the Kotlin Gradle Plugin.

I realized this is missing while writing [flutter#9857.](flutter/website#9857)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
e8282ed Update Android app project template to apply Kotlin Gradle pl…
92c1e67 
…ugin declaratively (flutter/flutter#139006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartekpacia @reidbaker