Skip to content

Marks Windows framework_tests_misc_leak_tracking to be unflaky #141676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

fluttergithubbot
Copy link
Contributor

The issue #140414 has been closed, and the test has been passing for 50 consecutive runs.
This test can be marked as unflaky.

@flutter-dashboard flutter-dashboard bot added c: flake Tests that sometimes, but not always, incorrectly pass c: tech-debt Technical debt, code quality, testing, etc. labels Jan 17, 2024
@github-actions github-actions bot removed the c: tech-debt Technical debt, code quality, testing, etc. label Jan 17, 2024
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 17, 2024
@auto-submit auto-submit bot merged commit 8286f49 into flutter:master Jan 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 18, 2024
flutter/flutter@def6af0...f77f824

2024-01-18 [email protected] Roll Flutter Engine from 49fa2cb9024f to b75d6d80d813 (1 revision) (flutter/flutter#141771)
2024-01-18 [email protected] Roll Flutter Engine from 49c6ca211aa4 to 49fa2cb9024f (1 revision) (flutter/flutter#141762)
2024-01-18 [email protected] Roll Flutter Engine from 873449c27d5a to 49c6ca211aa4 (1 revision) (flutter/flutter#141760)
2024-01-18 [email protected] Roll Flutter Engine from bfdc0c5b2826 to 873449c27d5a (1 revision) (flutter/flutter#141759)
2024-01-18 [email protected] Catch UnsupportedError thrown when user provides an asset directory path containing invalid characters (flutter/flutter#141214)
2024-01-18 [email protected] Roll Flutter Engine from 48f89ac064ac to bfdc0c5b2826 (1 revision) (flutter/flutter#141752)
2024-01-18 [email protected] Roll Flutter Engine from 924c17245a78 to 48f89ac064ac (2 revisions) (flutter/flutter#141751)
2024-01-18 [email protected] Roll Flutter Engine from 98c16b430e6b to 924c17245a78 (1 revision) (flutter/flutter#141749)
2024-01-18 [email protected] Roll Flutter Engine from 73a2de5da53f to 98c16b430e6b (16 revisions) (flutter/flutter#141744)
2024-01-18 [email protected] Move mac pixel 7 pro test to presubmit: false (flutter/flutter#141747)
2024-01-18 [email protected] [web] prepare layers_test.dart for flutter/engine#49786 (flutter/flutter#141731)
2024-01-17 [email protected] Remove non-needed bot and increase time out for leak_tracking. (flutter/flutter#141712)
2024-01-17 [email protected] Add `headerHeight` for `SearchAnchor` (flutter/flutter#141223)
2024-01-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/flutter#141715)
2024-01-17 [email protected] Make test file systems/platforms used in asset_bundle_test.dart less dependent on the host platform (flutter/flutter#141657)
2024-01-17 [email protected] Native assets: roll deps (flutter/flutter#141684)
2024-01-17 [email protected] Run build tests on both x64 and arm64. (flutter/flutter#141206)
2024-01-17 [email protected] Update tests to Xcode 15 (flutter/flutter#141706)
2024-01-17 [email protected] [web] prepare for flutter/engine#49786 (flutter/flutter#141700)
2024-01-17 [email protected] Marks Windows framework_tests_misc_leak_tracking to be unflaky (flutter/flutter#141676)
2024-01-17 [email protected] Label "flutter_localizations" PRs with "framework" (flutter/flutter#141654)
2024-01-17 [email protected] Fix Tooltip show delay when mouse moves to one Tooltip from another (flutter/flutter#141656)
2024-01-17 [email protected] Roll Packages from 7dd0fcb to 1a2b780 (6 revisions) (flutter/flutter#141683)
2024-01-17 [email protected] Fix the --empty flag to not try working with non-app templates (flutter/flutter#141632)
2024-01-17 [email protected] Revert "Roll Flutter Engine from 73a2de5da53f to c7e328518bc0 (5 revisions)" (flutter/flutter#141691)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: flake Tests that sometimes, but not always, incorrectly pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants