Skip to content

Revert "Reduce xcodebuild noise #2" #14641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Conversation

mravn-google
Copy link
Contributor

Reverts #14622

Reducing Xcode output seems to mean we fail to detect the target .app file, cf. #14640

@mit-mit
Copy link
Member

mit-mit commented Feb 12, 2018

RSLGTM

@mravn-google mravn-google merged commit 2d47481 into master Feb 12, 2018
@xster xster mentioned this pull request Feb 13, 2018
xster added a commit to xster/flutter that referenced this pull request Feb 13, 2018
xster added a commit that referenced this pull request Feb 13, 2018
* Revert "Revert "Reduce xcodebuild noise #2" (#14641)"

This reverts commit 2d47481.

* Stop scrapping xcodebuild output, get the right build settings

* clone the command params first
@tvolkert tvolkert deleted the revert-14622-xcodebuild-noise branch February 26, 2018 19:45
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
Merging to get back to a green tree.
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
* Revert "Revert "Reduce xcodebuild noise flutter#2" (flutter#14641)"

This reverts commit 2d47481.

* Stop scrapping xcodebuild output, get the right build settings

* clone the command params first
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants