Skip to content

fixed_carousel_optinal_tap_event #154745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yeasin50
Copy link
Contributor

@yeasin50 yeasin50 commented Sep 6, 2024

Fixes #154701 CarouselView children are not clickable

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 6, 2024
Copy link
Contributor

@nate-thegrate nate-thegrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yeasin50, thanks for contributing!

This PR will need a test to make sure we don't accidentally undo the fix in the future (as per the bot comment), and the existing tests need to pass as well.

Feel free to reply here if you have questions!

@Piinks
Copy link
Contributor

Piinks commented Sep 11, 2024

This looks like a duplicate of #153162, but we have not heard back from them. Just FYI as this progresses.

@Piinks
Copy link
Contributor

Piinks commented Sep 25, 2024

Another PR has been opened for this, #155214. If we have not heard back on this, we may go ahead with landing that PR if it resolves the issue.

@Piinks
Copy link
Contributor

Piinks commented Oct 2, 2024

Since #154701 was merged, this issue has now been resolved, so I am going to close this PR. Thank you @yeasin50 for contributing!

@Piinks Piinks closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CarouselView children are not clickable
3 participants