Skip to content

Conversation

liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Mar 18, 2019

Need this manual roll because of golden changes.

flutter/engine@5088735e5 Clip to clip_rect instead of paint bounds (flutter/engine#8183)
flutter/engine@8818a6c41 Roll src/third_party/skia 2c043c288169..4a522b7e916c (3 commits) (flutter/engine#8201)

@liyuqian
Copy link
Contributor Author

Note that all tests shall fail until the engine build bots uploaded the artifacts.

@liyuqian liyuqian force-pushed the manual_roll_508873 branch from a23d7bd to 377c673 Compare March 18, 2019 22:00
@goderbauer goderbauer added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Mar 18, 2019
@liyuqian liyuqian force-pushed the manual_roll_508873 branch from 377c673 to 874a14e Compare March 18, 2019 22:27
Need this manual roll because of golden changes.

flutter/engine@5088735e5 Clip to clip_rect instead of paint bounds (flutter/engine#8183)
flutter/engine@8818a6c41 Roll src/third_party/skia 2c043c288169..4a522b7e916c (3 commits) (flutter/engine#8201)
flutter/engine@048d70bc0 Support dartdevc, dart2js with shared source files, dartdevc sdk (flutter/engine#8105)
flutter/engine@e0782dec7 Roll src/third_party/skia 576b2a5596bc..2c043c288169 (2 commits) (flutter/engine#8200)
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyuqian liyuqian merged commit 79e3bf4 into flutter:master Mar 19, 2019
@liyuqian liyuqian deleted the manual_roll_508873 branch March 28, 2019 22:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants