Skip to content

New dwds #41805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

New dwds #41805

wants to merge 8 commits into from

Conversation

alan-knight
Copy link
Contributor

Description

This updates flutter_tool to use dwds 0.7.0, which has a breaking change in its creation API. It passes an asset handler which replaces several other parameters.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • [ x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [not required for googlers] I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • [x ] No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 2, 2019
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@alan-knight
Copy link
Contributor Author

This fails because I manually updated the pubspec, but shows the changes necessary to use a 0.7.x dwds. We also expect to have a 0.7.1 with a few more fixes for Flutter issues very shortly.

@jonahwilliams
Copy link
Member

Sounds good - you can update the pubspecs for this PR with flutter update-packages --force-upgrade FWIW

@alan-knight
Copy link
Contributor Author

OK. I had been reluctant to do that for fear of coupling it to other things, but did it now.

@jonahwilliams
Copy link
Member

Ahh I see you ended up with the build_runner roll too. Could you update these lines:

https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/build_runner/build_script.dart#L219

To remove the skipPlatformCheckPackages and replace it with skipPlatformCheck: true?

If not, I can take over this PR to finish it

@alan-knight
Copy link
Contributor Author

Added the build_runner fix.

@jonahwilliams
Copy link
Member

Sorry, looks like there is one more at packages/flutter_tools/lib/src/build_runner/build_script.dart:245

@DanTup
Copy link
Contributor

DanTup commented Oct 7, 2019

🎉

Screenshot 2019-10-07 at 10 20 54 am

@jonahwilliams
Copy link
Member

Looks like we managed to roll this in with #41936

@alan-knight
Copy link
Contributor Author

OK.

@alan-knight alan-knight closed this Oct 7, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants