-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New dwds #41805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New dwds #41805
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This fails because I manually updated the pubspec, but shows the changes necessary to use a 0.7.x dwds. We also expect to have a 0.7.1 with a few more fixes for Flutter issues very shortly. |
Sounds good - you can update the pubspecs for this PR with |
OK. I had been reluctant to do that for fear of coupling it to other things, but did it now. |
Ahh I see you ended up with the build_runner roll too. Could you update these lines: To remove the skipPlatformCheckPackages and replace it with If not, I can take over this PR to finish it |
Added the build_runner fix. |
Sorry, looks like there is one more at packages/flutter_tools/lib/src/build_runner/build_script.dart:245 |
Looks like we managed to roll this in with #41936 |
OK. |
Description
This updates flutter_tool to use dwds 0.7.0, which has a breaking change in its creation API. It passes an asset handler which replaces several other parameters.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?