Add support for --coverage to flutter test #4679
Conversation
abarth
force-pushed
the
coverage
branch
2 times, most recently
from
e23be59 to
c975c1b
Compare
We need https://github.com/dart-lang/coverage/issues/100 to be fixed before this will be useful. Fixes flutter#2342
|
Heads up: dart-lang/tools#561 is now fixed. |
| printTrace('formating coverage data'); | ||
| // TODO(abarth): Use PackageMap.globalPackagesPath once | ||
| // https://github.com/dart-lang/coverage/issues/100 is fixed. | ||
| Resolver resolver = new Resolver(packageRoot: path.absolute('packages')); |
There was a problem hiding this comment.
New param in 0.7.8 is packagesPath (String path to .packages file)
|
It's clearly dangerous putting you two in a room together. :) So excited to try this out! |
| @@ -105,8 +112,16 @@ void main() { | |||
| } | |||
| '''); | |||
|
|
|||
| int observatoryPort; | |||
There was a problem hiding this comment.
My understanding was the dart vm would pick an open port if you passed --observatory-port=0, and then we had code to read said port from the logs, etc. Maybe that won't work through our package:test integration? Devon might know.
There was a problem hiding this comment.
Yeah, I didn't want to mess with reading the port back from the logs. Seemed easier to push the port number in via a command-line parameter.
There was a problem hiding this comment.
We do have code in os.dart - findAvailablePort() - that tries to find an available local port. I'm not sure it's more reliable than the random generator below however -
|
This is ready for review now. |
|
|
* use TextDecoration enums * replace GetBlobLength with a function that returns runs based on typeface * a few other minor style fixes
We need dart-lang/tools#561 to be fixed before
this will be useful.
Fixes #2342