-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Mobile perf tests seem to be broken in newer versions #275
Comments
CC @guidezpl |
I think the root cause is a workaround was removed for flutter/flutter#64432 (and the previous attempt) to land. The Internal tests are still failing for the reland, so 2 options.
|
Since flutter/flutter#64432 is actively being worked on, let's choose option 1 for now as the mobile tests would still pass in Flutter if we don't roll the gallery version. We can recheck this issue in 1 week and see if flutter/flutter#64432 is merged. If so, we can close this issue and roll the Gallery version. Otherwise, we can choose option 2 by then. |
Sounds good, I agree |
flutter/flutter#64432 landed but got reverted again. Would you like to proceed with option 2? |
There's a separate PR that looks like it will close the issue flutter/flutter#65703. Let's see if this one sticks |
That PR has landed 🎉 so I think we can close this issue |
Cool, I'm going to close this and roll the gallery version in Flutter repo. |
This shouldn't break our tests as flutter/gallery#275 is closed.
This shouldn't break our tests as flutter/gallery#275 is closed.
Uh oh!
There was an error while loading. Please reload this page.
When Flutter tries to roll from the old version a208eac to the new version 9eb1ff8, following tests start to fail
The log seems to suggest that some scrolling failed.
The Crane test doesn't fail so presumably some other parts failed.
See also flutter/flutter#64824 for the context.
The text was updated successfully, but these errors were encountered: