Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Mobile perf tests seem to be broken in newer versions #275

Closed
liyuqian opened this issue Aug 29, 2020 · 8 comments
Closed

Mobile perf tests seem to be broken in newer versions #275

liyuqian opened this issue Aug 29, 2020 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@liyuqian
Copy link
Contributor

liyuqian commented Aug 29, 2020

When Flutter tries to roll from the old version a208eac to the new version 9eb1ff8, following tests start to fail

  • new_gallery_transition_perf
  • new_gallery_ios__transition_perf

The log seems to suggest that some scrolling failed.

stdout: [        ] 00:15 �[32m+1�[0m�[31m -1�[0m: Flutter Gallery transitions all demos �[1m�[31m[E]�[0m�[0m
2020-08-28T13:44:18.275690: stdout: [   +1 ms]   DriverError: Failed to fulfill Scroll due to remote error
stdout: [        ]   Original error: Bad state: The client closed with pending request "ext.flutter.driver".

The Crane test doesn't fail so presumably some other parts failed.

See also flutter/flutter#64824 for the context.

@liyuqian liyuqian added the bug Something isn't working label Aug 29, 2020
@liyuqian
Copy link
Contributor Author

CC @guidezpl

@guidezpl guidezpl self-assigned this Sep 1, 2020
@guidezpl
Copy link
Member

guidezpl commented Sep 2, 2020

I think the root cause is a workaround was removed for flutter/flutter#64432 (and the previous attempt) to land. The Internal tests are still failing for the reland, so 2 options.

  1. Wait until this relands, with the mobile tests failing until then
  2. Revert Remove isolates workaround #256, roll gallery version to latest, and un-revert (with no Gallery version rolls until the aforementioned PR relands)

@liyuqian
Copy link
Contributor Author

liyuqian commented Sep 2, 2020

Since flutter/flutter#64432 is actively being worked on, let's choose option 1 for now as the mobile tests would still pass in Flutter if we don't roll the gallery version.

We can recheck this issue in 1 week and see if flutter/flutter#64432 is merged. If so, we can close this issue and roll the Gallery version. Otherwise, we can choose option 2 by then.

@guidezpl
Copy link
Member

guidezpl commented Sep 3, 2020

Sounds good, I agree

@liyuqian
Copy link
Contributor Author

flutter/flutter#64432 landed but got reverted again. Would you like to proceed with option 2?

@guidezpl
Copy link
Member

There's a separate PR that looks like it will close the issue flutter/flutter#65703. Let's see if this one sticks

@guidezpl
Copy link
Member

That PR has landed 🎉 so I think we can close this issue

@liyuqian
Copy link
Contributor Author

Cool, I'm going to close this and roll the gallery version in Flutter repo.

liyuqian added a commit to liyuqian/flutter that referenced this issue Sep 24, 2020
This shouldn't break our tests as
flutter/gallery#275 is closed.
liyuqian added a commit to flutter/flutter that referenced this issue Sep 25, 2020
This shouldn't break our tests as
flutter/gallery#275 is closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants