Skip to content

Conversation

dhuma1981
Copy link

Description

Part of flutter/flutter#170982

Refactored TabBarTheme to TabBarThemeData

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

google-cla bot commented Jun 25, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@tirth-patel-nc tirth-patel-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the build will fail since the project isn't using Flutter 3.32.4. Might need additional work.

@Piinks
Copy link
Contributor

Piinks commented Aug 25, 2025

Hi @dhuma1981 it looks like we aren't able to land this change as it is currently until we can make some updates in this repo. Thank you for contribution, for now I am going to close this PR while we see if we can make some updates. Thanks!

@Piinks Piinks closed this Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants