Skip to content

fix: [go_router] Extra parameter is always null in route level redirect callback #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

fix: [go_router] Extra parameter is always null in route level redirect callback #2308

wants to merge 9 commits into from

Conversation

Semapl3
Copy link
Contributor

@Semapl3 Semapl3 commented Jul 5, 2022 •
edited by chunhtai
Loading

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla
Copy link

google-cla bot commented Jul 5, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@DamienMrtl
Copy link

Please allow this merge it fixes a regression

chunhtai
chunhtai reviewed Jul 22, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Semapl3 Thanks for the fix, can you add a test to make sure we don't accidentally revert it?

Semapl3 added 3 commits July 23, 2022 03:18
@Semapl3
feat: add test flutter/flutter#106164
dbbc5a5
@Semapl3
Merge remote-tracking branch 'origin_of/main'
4ff6ebe 
# Conflicts:
#	packages/go_router/CHANGELOG.md
#	packages/go_router/lib/src/go_route_information_parser.dart
#	packages/go_router/pubspec.yaml
@Semapl3
fix: after merge
75aa2d9
@Semapl3
Copy link
Contributor Author

Semapl3 commented Jul 22, 2022

@chunhtai, fixed for 4.2.1 and test ready. Check please

chunhtai
chunhtai approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it looks like there is a merge conflict, please rebase off the latest main branch

@chunhtai chunhtai requested a review from johnpryan August 1, 2022 17:40
@chunhtai
Copy link
Contributor

chunhtai commented Aug 1, 2022

cc john for secondary review

@johnpryan
Copy link
Contributor

It looks like this is breaking tests in go_router_builder

@Semapl3 Semapl3 mentioned this pull request Aug 2, 2022
Merged
@Semapl3
Copy link
Contributor Author

Semapl3 commented Aug 2, 2022

#2404

@Semapl3 Semapl3 closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnpryan johnpryan johnpryan approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
needs tests p: go_router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[go_router] Extra parameter is always null in route level redirect callback
4 participants
@Semapl3 @DamienMrtl @chunhtai @johnpryan