-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[go_router] Don't clear listeners when logging is disabled #2533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
go_router should not clear listeners on the root logger Fixes #106653
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You guys are incredible. Thank you. Just one more thing.
It may be confusing why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
auto label is removed for flutter/packages, pr: 2533, Failed to merge pr#: 2533 with OperationException(linkException: null, graphqlErrors: [GraphQLError(message: Base branch was modified. Review and try the merge again., locations: [ErrorLocation(line: 2, column: 3)], path: [mergePullRequest], extensions: null)]). |
@johnpryan It looks like there is merge conflict |
go_router should not clear listeners on the root logger. See also dart-archive/logging#118
cc: @devoncarew
Fixes flutter/flutter#106653