[cross_file] Fix accidental constructor change

[stuartmorgan-g]

In #3095 I accidentally changed a constructor argument's nullability because I wasn't familiar with the correct variation of super parameters, and addressed a lint warning incorrectly. That version has been retracted; this restores the original behavior.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I listed at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

[stuartmorgan-g]

The test is convoluted, but it works (and is arguably no more convoluted than the three-files-that-must-match structure of the class itself).

[stuartmorgan-g]

Filed dart-lang/sdk#51196 for the false positive.

Although it's not actually clear to me why XFileBase has a constructor at all. Do you know what the reason was?

[asashour]

A humble suggestion, the code could be written as:

  XFile(
    String super.path, {
    String? mimeType,
    ...
  }) {

[stuartmorgan-g]

A humble suggestion, the code could be written as

Indeed; fixed, and updated the PR description to reflect that the analyzer wasn't at all the problem. Thanks!

[ditman]

LGTM! Thanks for the test!!

[ditman]

it's not actually clear to me why XFileBase has a constructor at all. Do you know what the reason was?

@stuartmorgan I don't remember, my only suspicion is to attempt to mandate that all subclasses (at least) have a path parameter? Not sure that's a valid solution (or requirement!)