[google_maps_flutter_web] Add padding to newLatLngBounds implementation #3452
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Increase version and write changes to changelog Add test for newLatLngBounds
|
@ditman Can you do the initial review here? It looks like this one should be pretty quick. |
|
@stuartmorgan @ditman Is there any update here? |
|
Update from triage: This is just waiting for @ditman to have bandwidth to review maps PRs. |
There was a problem hiding this comment.
Thanks for cleaning this up! Apart of a version update to clear the conflicts, if possible it'd be nice to have a test that actually verifies that the padding value is doing something with the rendering of the map. Other than that minor nitpick, this should be ready to go!
...es/google_maps_flutter/google_maps_flutter_web/example/integration_test/projection_test.dart
Outdated
Show resolved
Hide resolved
fix build number
There was a problem hiding this comment.
Thanks for the new test, I like it better than before and actually exercises the new code paths. LatLngBounds has an overridden == operator, so the comparisons should work as intended.
Very minor change, but please format the changelog using the style guide. (I've suggested a new line, but feel free to rewrite however sounds best to you)
packages/google_maps_flutter/google_maps_flutter_web/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Co-authored-by: David Iglesias <[email protected]>
There was a problem hiding this comment.
LGTM!
Please @stuartmorgan, do take a look for a second review here (you've dealt with convert.dart before :P)
stuartmorgan-g
added
autosubmit
flutter/packages@d4752c4...53ed5a0 2023-06-30 [email protected] [google_maps_flutter_web] Add padding to newLatLngBounds implementation (flutter/packages#3452) 2023-06-29 [email protected] [various] Remove unused flutter_driver dependencies (flutter/packages#4347) 2023-06-29 [email protected] [ci] Add LUCI version of dart unit tests (flutter/packages#4265) 2023-06-29 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.21 to 1.8.22 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4189) 2023-06-29 [email protected] [shared_preferences] Adds new clearWithParameters and getAllWithParameters methods to all platforms. (flutter/packages#4262) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Description
This PR is implementing the
paddingargument tofitBoundswhich is called bynewLatLngBounds.Related Issues
flutter/flutter#122192
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.