[tool] Check Java integration test configuration #3499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than ignoring files by filename convention (*ActivityTest.java), look for the @DartIntegrationTest annotation that the test filter actually uses, to prevent accidentally excluding files. Also validate that the annotation is present when it should be, so that forgetting to add it doesn't cause unexplained hangs when running locally.
tarrinneal
approved these changes
Mar 20, 2023
reidbaker
approved these changes
Mar 20, 2023
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages, pr: 3499, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
autosubmit
|
Overriding stale tree status. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
[tool] Check Java integration test configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than ignoring files by filename convention (*ActivityTest.java), look for the @DartIntegrationTest annotation that the test filter actually uses, to prevent accidentally excluding files.
Also validate that the annotation is present when it should be, so that forgetting to add it doesn't cause unexplained hangs when running locally.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).