Skip to content

Adding autosubmit configuration pointer file #3521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2023

Conversation

ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented Mar 22, 2023

Adding the pointer file that points to the autosubmit configuration in flutter/.github.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.


# This file will be added to flutter's internal repository.
# TODO: publish design doc and link here.
config_path: 'autosubmit/flutter/autosubmit_main.yml'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a newline before EOF?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay it did but for some reason there is something in this repo that removes the empty line. Adding two empty lines fixed the issue.

@ricardoamador ricardoamador changed the title Adding autosubmit pointer file Adding autosubmit configuration pointer file Mar 23, 2023
@ricardoamador ricardoamador merged commit 32c120f into flutter:main Mar 24, 2023
@ricardoamador ricardoamador deleted the autosubmit branch March 24, 2023 02:17
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
* Adding autosubmit pointer file

* Forgot to add a space before EOF.

* Updated with link to wiki.

* Addign newline on end of file.

* Remove trailing blank line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants