Skip to content

[webview_flutter] Fix typos in tests and documentation #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2023
Merged

[webview_flutter] Fix typos in tests and documentation #3572

merged 4 commits into from
Apr 7, 2023

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Mar 28, 2023 •
edited
Loading

Updates typos. No tests added for typos that only change documentation.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines requested a review from cyanglaz as a code owner March 28, 2023 17:19
@bparrishMines bparrishMines changed the title Webview flutter typos [webview_flutter] Fix numerous typos in tests and documentation Mar 28, 2023
@bparrishMines bparrishMines changed the title [webview_flutter] Fix numerous typos in tests and documentation [webview_flutter] Fix typos in tests and documentation Apr 6, 2023
@bparrishMines bparrishMines added the override: no versioning needed Override the check requiring version bumps for most changes label Apr 6, 2023
@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2023
@auto-submit auto-submit bot merged commit 75ede70 into flutter:main Apr 7, 2023
@bparrishMines bparrishMines deleted the webview_flutter_typos branch April 7, 2023 02:11
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 7, 2023
@engine-flutter-autoroll
75ede70 [webview_flutter] Fix typos in tests and documentation (flutt…
19e432a 
…er/packages#3572)
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@bparrishMines @nploi
[webview_flutter] Fix typos in tests and documentation (flutter#3572)
23fdbaf 
[webview_flutter] Fix typos in tests and documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no versioning needed Override the check requiring version bumps for most changes p: webview_flutter platform-android platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bparrishMines @tarrinneal