Skip to content

[all_packages] Bump minimum SDK version #3581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions script/tool/lib/src/create_all_packages_app_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,8 @@ class CreateAllPackagesAppCommand extends PackageCommand {
final StringBuffer newGradle = StringBuffer();
for (final String line in gradleFile.readAsLinesSync()) {
if (line.contains('minSdkVersion')) {
// minSdkVersion 20 is required by Google maps.
// minSdkVersion 19 is required by WebView.
newGradle.writeln('minSdkVersion 20');
// minSdkVersion 21 is required by camera_android.
newGradle.writeln('minSdkVersion 21');
} else if (line.contains('compileSdkVersion')) {
// compileSdkVersion 33 is required by local_auth.
newGradle.writeln('compileSdkVersion 33');
Expand Down