Skip to content

[camerax] Implement onCameraClosing #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 91 commits into from
May 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
6125eca
Recreating image capture impl from flutter/plugins
camsim99 Feb 23, 2023
5be1371
Merge remote-tracking branch 'upstream/main' into camx_imgcap
camsim99 Feb 23, 2023
b2fce3d
Fix integration tesT
camsim99 Feb 23, 2023
ed62a9a
Merge branch 'main' into camx_imgcap
camsim99 Feb 23, 2023
2e3027b
Analyzer pt 2
camsim99 Feb 23, 2023
fbd3fe5
Merge branch 'camx_imgcap' of github.com:camsim99/packages into camx_…
camsim99 Feb 23, 2023
dfa477e
Personal cleanup
camsim99 Feb 23, 2023
a651b92
Add initialization of controller
camsim99 Feb 24, 2023
884fd6c
Merge remote-tracking branch 'upstream/main' into camx_imgcap
camsim99 Feb 24, 2023
d5f8b91
Modify some docs
camsim99 Feb 24, 2023
060b7e5
Address review
camsim99 Mar 2, 2023
ff50c70
Merge remote-tracking branch 'upstream/main' into camx_imgcap
camsim99 Mar 2, 2023
fe6f1fc
Fix analyze
camsim99 Mar 2, 2023
e2643ae
Update packages/camera/camera_android_camerax/android/src/main/java/i…
camsim99 Mar 3, 2023
b7194f7
Update packages/camera/camera_android_camerax/lib/src/image_capture.dart
camsim99 Mar 3, 2023
dadc230
Start addressing review
camsim99 Mar 6, 2023
d15e1d4
Finish addressing review
camsim99 Mar 7, 2023
6dc2b77
Fix analyze
camsim99 Mar 7, 2023
f826b62
Generate mocks on stable
camsim99 Mar 7, 2023
0f7f29a
Fix/add tests
camsim99 Mar 7, 2023
1e9739b
Add isBound dart test
camsim99 Mar 7, 2023
9ba20d0
Merge remote-tracking branch 'upstream/main' into camx_imgcap
camsim99 Mar 13, 2023
5bf6b17
Start dev
camsim99 Mar 8, 2023
5e58b2c
Add cameraClosing impl
camsim99 Mar 8, 2023
4c8c94d
Add tests
camsim99 Mar 13, 2023
6a0de08
Implement occ with camera state
camsim99 Mar 14, 2023
d3ed3e7
Reimplement with live camera state
camsim99 Mar 15, 2023
d1c684f
Start adding tests
camsim99 Mar 22, 2023
c04d8c1
Add java tests
camsim99 Mar 22, 2023
b2322d2
Formatting
camsim99 Mar 22, 2023
3545aec
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 Mar 22, 2023
e1f5bdb
Fix flutter analyze
camsim99 Mar 22, 2023
2d3409b
Fix analyze
camsim99 Mar 22, 2023
1f40f47
Review
camsim99 Mar 22, 2023
6c9b04e
Fix tests, review 2
camsim99 Mar 23, 2023
6c6cbb4
review 3
camsim99 Mar 23, 2023
a0ea3c5
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 Mar 23, 2023
06c1545
fix analyze
camsim99 Mar 23, 2023
681a117
Fix cast
camsim99 Mar 23, 2023
1143a03
generate mocks on stable
camsim99 Mar 23, 2023
d431511
Formatting
camsim99 Mar 24, 2023
ab3c085
Add missing tests
camsim99 Mar 24, 2023
631f972
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 Mar 24, 2023
70c817a
Fix analyze
camsim99 Mar 24, 2023
426b438
Bump camerax version
camsim99 Mar 27, 2023
2bc4877
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 Mar 28, 2023
0fcf7c6
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 Mar 29, 2023
6c49bd9
Formatting
camsim99 Mar 29, 2023
b9daeb1
pair programming w/maurice
camsim99 Apr 11, 2023
3345878
Fixing plugin
camsim99 Apr 12, 2023
9f6646f
Current status
camsim99 Apr 13, 2023
265eb1e
Remove print statements
camsim99 Apr 14, 2023
bfc4b5e
Add print
camsim99 Apr 14, 2023
4f3c342
remove comments
camsim99 Apr 14, 2023
e3c7a5b
Review 2
camsim99 Apr 17, 2023
f341f7f
Fixing tests
camsim99 Apr 18, 2023
0d4b021
Fix tests, format
camsim99 Apr 18, 2023
ca3bd9e
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 Apr 18, 2023
540ee98
Fix test
camsim99 Apr 18, 2023
debcd3a
Fix camera test
camsim99 Apr 18, 2023
a79ee62
Start addressing review
camsim99 Apr 25, 2023
438f592
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 May 1, 2023
c44fc06
Address review, remove cast
camsim99 May 1, 2023
83aea10
Fix java tests
camsim99 May 1, 2023
5f435e8
Fix dart tests
camsim99 May 1, 2023
581af94
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 May 1, 2023
dec3d69
Merge remote-tracking branch 'upstream/main' into camx_occ
camsim99 May 1, 2023
02c039f
Merge branch 'camx_occ' into camx_occ_3
camsim99 May 1, 2023
ce463ba
Undo changes to other packages
camsim99 May 1, 2023
c525162
Undo non-camera changes
camsim99 May 1, 2023
86304c3
Add getValue
camsim99 May 2, 2023
b826c18
Fix tests
camsim99 May 2, 2023
2cebb18
Add log and formatting
camsim99 May 2, 2023
04976ec
Add period
camsim99 May 2, 2023
bca72ee
Fix android test errors
camsim99 May 2, 2023
2da0b8f
Merge remote-tracking branch 'upstream/main' into camx_occ_3
camsim99 May 2, 2023
ea78ab0
fix tests
camsim99 May 3, 2023
d0b160f
Formatting
camsim99 May 3, 2023
bc7ebee
Fix tests
camsim99 May 3, 2023
9014d3b
Add mock files
camsim99 May 3, 2023
f3d6a06
Addres test comments
camsim99 May 3, 2023
34cab98
Address rest of review
camsim99 May 3, 2023
6f701a5
Address maurice review
camsim99 May 3, 2023
a636525
Address reviews
camsim99 May 4, 2023
d5a21cb
Improve comments
camsim99 May 5, 2023
bc4ebc1
Update packages/camera/camera_android_camerax/lib/src/android_camera_…
camsim99 May 8, 2023
491ab2c
Apply patch + fix dispose
camsim99 May 8, 2023
bff96a9
Merge branch 'camx_occ_3' of github.com:camsim99/packages into camx_o…
camsim99 May 8, 2023
ad40999
Merge remote-tracking branch 'upstream/main' into camx_occ_3
camsim99 May 8, 2023
a3667dd
Merge remote-tracking branch 'upstream/main' into camx_occ_3
camsim99 May 9, 2023
c3732fe
Merge remote-tracking branch 'upstream/main' into camx_occ_3
camsim99 May 9, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/camera/camera_android_camerax/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@
* Implements retrieval of camera information.
* Updates README.md with plugin overview and adds contribution guide to CONTRIBUTING.md.
* Implements video capture.
* Implements onCameraClosing callback method for indicating the camera is closing and bumps CameraX version to 1.3.0-alpha05.

Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ android {

dependencies {
// CameraX core library using the camera2 implementation must use same version number.
def camerax_version = "1.3.0-alpha04"
def camerax_version = "1.3.0-alpha05"
implementation "androidx.camera:camera-core:${camerax_version}"
implementation "androidx.camera:camera-camera2:${camerax_version}"
implementation "androidx.camera:camera-lifecycle:${camerax_version}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ public final class CameraAndroidCameraxPlugin implements FlutterPlugin, Activity
private ImageCaptureHostApiImpl imageCaptureHostApiImpl;
public SystemServicesHostApiImpl systemServicesHostApiImpl;

@VisibleForTesting ProcessCameraProviderHostApiImpl processCameraProviderHostApiImpl;
@VisibleForTesting @NonNull
public ProcessCameraProviderHostApiImpl processCameraProviderHostApiImpl;

@VisibleForTesting @NonNull public LiveDataHostApiImpl liveDataHostApiImpl;

/**
* Initialize this within the {@code #configureFlutterEngine} of a Flutter activity or fragment.
Expand Down Expand Up @@ -71,6 +74,12 @@ public void setUp(
imageCaptureHostApiImpl =
new ImageCaptureHostApiImpl(binaryMessenger, instanceManager, context);
GeneratedCameraXLibrary.ImageCaptureHostApi.setup(binaryMessenger, imageCaptureHostApiImpl);
GeneratedCameraXLibrary.CameraHostApi.setup(
binaryMessenger, new CameraHostApiImpl(binaryMessenger, instanceManager));
liveDataHostApiImpl = new LiveDataHostApiImpl(binaryMessenger, instanceManager);
GeneratedCameraXLibrary.LiveDataHostApi.setup(binaryMessenger, liveDataHostApiImpl);
GeneratedCameraXLibrary.ObserverHostApi.setup(
binaryMessenger, new ObserverHostApiImpl(binaryMessenger, instanceManager));
imageAnalysisHostApiImpl = new ImageAnalysisHostApiImpl(binaryMessenger, instanceManager);
GeneratedCameraXLibrary.ImageAnalysisHostApi.setup(binaryMessenger, imageAnalysisHostApiImpl);
GeneratedCameraXLibrary.AnalyzerHostApi.setup(
Expand Down Expand Up @@ -105,19 +114,18 @@ public void onDetachedFromEngine(@NonNull FlutterPluginBinding binding) {

@Override
public void onAttachedToActivity(@NonNull ActivityPluginBinding activityPluginBinding) {
setUp(
pluginBinding.getBinaryMessenger(),
pluginBinding.getApplicationContext(),
pluginBinding.getTextureRegistry());
updateContext(pluginBinding.getApplicationContext());

Activity activity = activityPluginBinding.getActivity();

setUp(pluginBinding.getBinaryMessenger(), activity, pluginBinding.getTextureRegistry());
updateContext(activity);

if (activity instanceof LifecycleOwner) {
processCameraProviderHostApiImpl.setLifecycleOwner((LifecycleOwner) activity);
liveDataHostApiImpl.setLifecycleOwner((LifecycleOwner) activity);
} else {
ProxyLifecycleProvider proxyLifecycleProvider = new ProxyLifecycleProvider(activity);
processCameraProviderHostApiImpl.setLifecycleOwner(proxyLifecycleProvider);
liveDataHostApiImpl.setLifecycleOwner(proxyLifecycleProvider);
}

systemServicesHostApiImpl.setActivity(activity);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@ public Long getCameraInfo(@NonNull Long identifier) {
Camera camera = (Camera) Objects.requireNonNull(instanceManager.getInstance(identifier));
CameraInfo cameraInfo = camera.getCameraInfo();

CameraInfoFlutterApiImpl cameraInfoFlutterApiImpl =
new CameraInfoFlutterApiImpl(binaryMessenger, instanceManager);
cameraInfoFlutterApiImpl.create(cameraInfo, reply -> {});

if (!instanceManager.containsInstance(cameraInfo)) {
CameraInfoFlutterApiImpl cameraInfoFlutterApiImpl =
new CameraInfoFlutterApiImpl(binaryMessenger, instanceManager);
cameraInfoFlutterApiImpl.create(cameraInfo, reply -> {});
}
return instanceManager.getIdentifierForStrongReference(cameraInfo);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ public CameraInfoFlutterApiImpl(
this.instanceManager = instanceManager;
}

/**
* Creates a {@link CameraInfo} instance in Dart. {@code reply} is not used so it can be empty.
*/
void create(CameraInfo cameraInfo, Reply<Void> reply) {
if (!instanceManager.containsInstance(cameraInfo)) {
create(instanceManager.addHostCreatedInstance(cameraInfo), reply);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,35 @@
package io.flutter.plugins.camerax;

import androidx.annotation.NonNull;
import androidx.annotation.VisibleForTesting;
import androidx.camera.core.CameraInfo;
import androidx.camera.core.CameraState;
import androidx.camera.core.ExposureState;
import androidx.camera.core.ZoomState;
import androidx.lifecycle.LiveData;
import io.flutter.plugin.common.BinaryMessenger;
import io.flutter.plugins.camerax.GeneratedCameraXLibrary.CameraInfoHostApi;
import io.flutter.plugins.camerax.GeneratedCameraXLibrary.LiveDataSupportedType;
import java.util.Objects;

public class CameraInfoHostApiImpl implements CameraInfoHostApi {
private final BinaryMessenger binaryMessenger;
private final InstanceManager instanceManager;

@VisibleForTesting public LiveDataFlutterApiWrapper liveDataFlutterApiWrapper;

public CameraInfoHostApiImpl(
@NonNull BinaryMessenger binaryMessenger, @NonNull InstanceManager instanceManager) {
this.binaryMessenger = binaryMessenger;
this.instanceManager = instanceManager;
this.liveDataFlutterApiWrapper =
new LiveDataFlutterApiWrapper(binaryMessenger, instanceManager);
}

/** Retrieves the sensor rotation in degrees, relative to the device's default orientation. */
/**
* Retrieves the sensor rotation degrees of the {@link androidx.camera.core.Camera} that is
* represented by the {@link CameraInfo} with the specified identifier.
*/
@Override
@NonNull
public Long getSensorRotationDegrees(@NonNull Long identifier) {
Expand All @@ -31,6 +42,22 @@ public Long getSensorRotationDegrees(@NonNull Long identifier) {
return Long.valueOf(cameraInfo.getSensorRotationDegrees());
}

/**
* Retrieves the {@link LiveData} of the {@link CameraState} that is tied to the {@link
* androidx.camera.core.Camera} that is represented by the {@link CameraInfo} with the specified
* identifier.
*/
@Override
@NonNull
public Long getCameraState(@NonNull Long identifier) {
CameraInfo cameraInfo =
(CameraInfo) Objects.requireNonNull(instanceManager.getInstance(identifier));
LiveData<CameraState> liveCameraState = cameraInfo.getCameraState();
liveDataFlutterApiWrapper.create(
liveCameraState, LiveDataSupportedType.CAMERA_STATE, reply -> {});
return instanceManager.getIdentifierForStrongReference(liveCameraState);
}

/**
* Retrieves the {@link ExposureState} of the {@link CameraInfo} with the specified identifier.
*/
Expand All @@ -49,20 +76,19 @@ public Long getExposureState(@NonNull Long identifier) {
}

/**
* Retrieves the current {@link ZoomState} value of the {@link CameraInfo} with the specified
* identifier.
* Retrieves the {@link LiveData} of the {@link ZoomState} of the {@link CameraInfo} with the
* specified identifier.
*/
@NonNull
@Override
public Long getZoomState(@NonNull Long identifier) {
CameraInfo cameraInfo =
(CameraInfo) Objects.requireNonNull(instanceManager.getInstance(identifier));
// TODO(camsim99): Create/return LiveData<ZoomState> once https://github.com/flutter/packages/pull/3419 lands.
ZoomState zoomState = cameraInfo.getZoomState().getValue();
LiveData<ZoomState> zoomState = cameraInfo.getZoomState();

ZoomStateFlutterApiImpl zoomStateFlutterApiImpl =
new ZoomStateFlutterApiImpl(binaryMessenger, instanceManager);
zoomStateFlutterApiImpl.create(zoomState, result -> {});
LiveDataFlutterApiWrapper liveDataFlutterApiWrapper =
new LiveDataFlutterApiWrapper(binaryMessenger, instanceManager);
liveDataFlutterApiWrapper.create(zoomState, LiveDataSupportedType.ZOOM_STATE, reply -> {});

return instanceManager.getIdentifierForStrongReference(zoomState);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

package io.flutter.plugins.camerax;

import androidx.annotation.NonNull;
import androidx.annotation.VisibleForTesting;
import androidx.camera.core.CameraState;
import io.flutter.plugin.common.BinaryMessenger;
import io.flutter.plugins.camerax.GeneratedCameraXLibrary.CameraStateErrorFlutterApi;

/**
* Flutter API implementation for {@link CameraStateError}.
*
* <p>This class may handle adding native instances that are attached to a Dart instance or passing
* arguments of callbacks methods to a Dart instance.
*/
public class CameraStateErrorFlutterApiWrapper {
private final BinaryMessenger binaryMessenger;
private final InstanceManager instanceManager;
private CameraStateErrorFlutterApi cameraStateErrorFlutterApi;

/**
* Constructs a {@link CameraStateErrorFlutterApiWrapper}.
*
* @param binaryMessenger used to communicate with Dart over asynchronous messages
* @param instanceManager maintains instances stored to communicate with attached Dart objects
*/
public CameraStateErrorFlutterApiWrapper(
@NonNull BinaryMessenger binaryMessenger, @NonNull InstanceManager instanceManager) {
this.binaryMessenger = binaryMessenger;
this.instanceManager = instanceManager;
cameraStateErrorFlutterApi = new CameraStateErrorFlutterApi(binaryMessenger);
}

/**
* Stores the {@link CameraStateError} instance and notifies Dart to create and store a new {@link
* CameraStateError} instance that is attached to this one. If {@code instance} has already been
* added, this method does nothing.
*/
public void create(
@NonNull CameraState.StateError instance,
@NonNull Long code,
@NonNull CameraStateErrorFlutterApi.Reply<Void> callback) {
if (!instanceManager.containsInstance(instance)) {
cameraStateErrorFlutterApi.create(
instanceManager.addHostCreatedInstance(instance), code, callback);
}
}

/** Sets the Flutter API used to send messages to Dart. */
@VisibleForTesting
void setApi(@NonNull CameraStateErrorFlutterApi api) {
this.cameraStateErrorFlutterApi = api;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

package io.flutter.plugins.camerax;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.annotation.VisibleForTesting;
import androidx.camera.core.CameraState;
import io.flutter.plugin.common.BinaryMessenger;
import io.flutter.plugins.camerax.GeneratedCameraXLibrary.CameraStateFlutterApi;
import io.flutter.plugins.camerax.GeneratedCameraXLibrary.CameraStateType;
import io.flutter.plugins.camerax.GeneratedCameraXLibrary.CameraStateTypeData;

/**
* Flutter API implementation for {@link CameraState}.
*
* <p>This class may handle adding native instances that are attached to a Dart instance or passing
* arguments of callbacks methods to a Dart instance.
*/
public class CameraStateFlutterApiWrapper {
private final BinaryMessenger binaryMessenger;
private final InstanceManager instanceManager;
private CameraStateFlutterApi cameraStateFlutterApi;

/**
* Constructs a {@link CameraStateFlutterApiWrapper}.
*
* @param binaryMessenger used to communicate with Dart over asynchronous messages
* @param instanceManager maintains instances stored to communicate with attached Dart objects
*/
public CameraStateFlutterApiWrapper(
@NonNull BinaryMessenger binaryMessenger, @NonNull InstanceManager instanceManager) {
this.binaryMessenger = binaryMessenger;
this.instanceManager = instanceManager;
cameraStateFlutterApi = new CameraStateFlutterApi(binaryMessenger);
}

/**
* Stores the {@link CameraState} instance and notifies Dart to create and store a new {@link
* CameraState} instance that is attached to this one. If {@code instance} has already been added,
* this method does nothing.
*/
public void create(
@NonNull CameraState instance,
@NonNull CameraStateType type,
@Nullable CameraState.StateError error,
@NonNull CameraStateFlutterApi.Reply<Void> callback) {
if (instanceManager.containsInstance(instance)) {
return;
}

if (error != null) {
// if there is a problem with the current camera state, we need to create a CameraStateError
// to send to the Dart side.
new CameraStateErrorFlutterApiWrapper(binaryMessenger, instanceManager)
.create(error, Long.valueOf(error.getCode()), reply -> {});
}

cameraStateFlutterApi.create(
instanceManager.addHostCreatedInstance(instance),
new CameraStateTypeData.Builder().setValue(type).build(),
instanceManager.getIdentifierForStrongReference(error),
callback);
}

/** Converts CameraX CameraState.Type to CameraStateType that the Dart side understands. */
@NonNull
public static CameraStateType getCameraStateType(@NonNull CameraState.Type type) {
CameraStateType cameraStateType = null;
switch (type) {
case CLOSED:
cameraStateType = CameraStateType.CLOSED;
break;
case CLOSING:
cameraStateType = CameraStateType.CLOSING;
break;
case OPEN:
cameraStateType = CameraStateType.OPEN;
break;
case OPENING:
cameraStateType = CameraStateType.OPENING;
break;
case PENDING_OPEN:
cameraStateType = CameraStateType.PENDING_OPEN;
break;
}

if (cameraStateType == null) {
throw new IllegalArgumentException(
"The CameraState.Type passed to this method was not recognized.");
}
return cameraStateType;
}

/** Sets the Flutter API used to send messages to Dart. */
@VisibleForTesting
void setApi(@NonNull CameraStateFlutterApi api) {
this.cameraStateFlutterApi = api;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,12 @@ public CameraSelector.Builder createCameraSelectorBuilder() {
return new CameraSelector.Builder();
}

/** Creates an instance of {@link CameraPermissionsManager}. */
public CameraPermissionsManager createCameraPermissionsManager() {
return new CameraPermissionsManager();
}

/** Creates an instance of the {@link DeviceOrientationManager}. */
public DeviceOrientationManager createDeviceOrientationManager(
@NonNull Activity activity,
@NonNull Boolean isFrontFacing,
Expand All @@ -44,16 +46,18 @@ public DeviceOrientationManager createDeviceOrientationManager(
return new DeviceOrientationManager(activity, isFrontFacing, sensorOrientation, callback);
}

/** Creates a builder for an instance of the {@link Preview} use case. */
public Preview.Builder createPreviewBuilder() {
return new Preview.Builder();
}

/** Creates a {@link Surface} instance from the specified {@link SurfaceTexture}. */
public Surface createSurface(@NonNull SurfaceTexture surfaceTexture) {
return new Surface(surfaceTexture);
}

/**
* Creates an instance of the {@code SystemServicesFlutterApiImpl}.
* Creates an instance of the {@link SystemServicesFlutterApiImpl}.
*
* <p>Included in this class to utilize the callback methods it provides, e.g. {@code
* onCameraError(String)}.
Expand All @@ -69,6 +73,7 @@ public Recorder.Builder createRecorderBuilder() {
return new Recorder.Builder();
}

/** Creates a builder for an instance of the {@link ImageCapture} use case. */
@NonNull
public ImageCapture.Builder createImageCaptureBuilder() {
return new ImageCapture.Builder();
Expand Down
Loading