-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[local_auth] Migrate iOS to Pigeon #3974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 15 commits into
flutter:main
from
stuartmorgan-g:local-auth-ios-pigeon
May 19, 2023
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
086e8ad
Remove useless check
stuartmorgan-g 093b0a2
Add todo for incorrect implementation to mark it as staying native
stuartmorgan-g 5b7888b
Initial Pigeon definition, modified from Android
stuartmorgan-g 10a3ab4
Adjust native implementation to conform to Pigeon API, adjusting Pige…
stuartmorgan-g e6a6a61
Update native tests, add missing test
stuartmorgan-g a97c41a
Update Dart implmeentation, modeled on Android
stuartmorgan-g ecd6e93
Replace Dart unit tests, based on Android
stuartmorgan-g 99c2963
Version bump
stuartmorgan-g 6bd50db
Autoformat
stuartmorgan-g 830a8df
Typo fix
stuartmorgan-g 167c018
Merge branch 'main' into local-auth-ios-pigeon
stuartmorgan-g 9794851
Typo fix
stuartmorgan-g 99f60e9
Rename result enum field
stuartmorgan-g 933c0d4
Other review fixes
stuartmorgan-g 3e707a8
Fix call sites
stuartmorgan-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
355 changes: 162 additions & 193 deletions
355
packages/local_auth/local_auth_ios/example/ios/RunnerTests/FLTLocalAuthPluginTests.m
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
293 changes: 150 additions & 143 deletions
293
packages/local_auth/local_auth_ios/ios/Classes/FLTLocalAuthPlugin.m
Large diffs are not rendered by default.
Oops, something went wrong.
123 changes: 123 additions & 0 deletions
123
packages/local_auth/local_auth_ios/ios/Classes/messages.g.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,123 @@ | ||
// Copyright 2013 The Flutter Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
// Autogenerated from Pigeon (v9.2.5), do not edit directly. | ||
// See also: https://pub.dev/packages/pigeon | ||
|
||
#import <Foundation/Foundation.h> | ||
|
||
@protocol FlutterBinaryMessenger; | ||
@protocol FlutterMessageCodec; | ||
@class FlutterError; | ||
@class FlutterStandardTypedData; | ||
|
||
NS_ASSUME_NONNULL_BEGIN | ||
|
||
/// Possible outcomes of an authentication attempt. | ||
typedef NS_ENUM(NSUInteger, FLAAuthResult) { | ||
/// The user authenticated successfully. | ||
FLAAuthResultSuccess = 0, | ||
/// The user failed to successfully authenticate. | ||
FLAAuthResultFailure = 1, | ||
/// The authentication system was not available. | ||
FLAAuthResultErrorNotAvailable = 2, | ||
/// No biometrics are enrolled. | ||
FLAAuthResultErrorNotEnrolled = 3, | ||
/// No passcode is set. | ||
FLAAuthResultErrorPasscodeNotSet = 4, | ||
}; | ||
|
||
/// Pigeon equivalent of the subset of BiometricType used by iOS. | ||
typedef NS_ENUM(NSUInteger, FLAAuthBiometric) { | ||
FLAAuthBiometricFace = 0, | ||
FLAAuthBiometricFingerprint = 1, | ||
}; | ||
|
||
@class FLAAuthStrings; | ||
@class FLAAuthOptions; | ||
@class FLAAuthResultDetails; | ||
@class FLAAuthBiometricWrapper; | ||
|
||
/// Pigeon version of IOSAuthMessages, plus the authorization reason. | ||
/// | ||
/// See auth_messages_ios.dart for details. | ||
@interface FLAAuthStrings : NSObject | ||
/// `init` unavailable to enforce nonnull fields, see the `make` class method. | ||
- (instancetype)init NS_UNAVAILABLE; | ||
+ (instancetype)makeWithReason:(NSString *)reason | ||
lockOut:(NSString *)lockOut | ||
goToSettingsButton:(NSString *)goToSettingsButton | ||
goToSettingsDescription:(NSString *)goToSettingsDescription | ||
cancelButton:(NSString *)cancelButton | ||
localizedFallbackTitle:(nullable NSString *)localizedFallbackTitle; | ||
@property(nonatomic, copy) NSString *reason; | ||
@property(nonatomic, copy) NSString *lockOut; | ||
@property(nonatomic, copy) NSString *goToSettingsButton; | ||
@property(nonatomic, copy) NSString *goToSettingsDescription; | ||
@property(nonatomic, copy) NSString *cancelButton; | ||
@property(nonatomic, copy, nullable) NSString *localizedFallbackTitle; | ||
@end | ||
|
||
@interface FLAAuthOptions : NSObject | ||
/// `init` unavailable to enforce nonnull fields, see the `make` class method. | ||
- (instancetype)init NS_UNAVAILABLE; | ||
+ (instancetype)makeWithBiometricOnly:(NSNumber *)biometricOnly | ||
sticky:(NSNumber *)sticky | ||
useErrorDialogs:(NSNumber *)useErrorDialogs; | ||
@property(nonatomic, strong) NSNumber *biometricOnly; | ||
@property(nonatomic, strong) NSNumber *sticky; | ||
@property(nonatomic, strong) NSNumber *useErrorDialogs; | ||
@end | ||
|
||
@interface FLAAuthResultDetails : NSObject | ||
/// `init` unavailable to enforce nonnull fields, see the `make` class method. | ||
- (instancetype)init NS_UNAVAILABLE; | ||
+ (instancetype)makeWithResult:(FLAAuthResult)result | ||
errorMessage:(nullable NSString *)errorMessage | ||
errorDetails:(nullable NSString *)errorDetails; | ||
/// The result of authenticating. | ||
@property(nonatomic, assign) FLAAuthResult result; | ||
/// A system-provided error message, if any. | ||
@property(nonatomic, copy, nullable) NSString *errorMessage; | ||
/// System-provided error details, if any. | ||
@property(nonatomic, copy, nullable) NSString *errorDetails; | ||
@end | ||
|
||
@interface FLAAuthBiometricWrapper : NSObject | ||
/// `init` unavailable to enforce nonnull fields, see the `make` class method. | ||
- (instancetype)init NS_UNAVAILABLE; | ||
+ (instancetype)makeWithValue:(FLAAuthBiometric)value; | ||
@property(nonatomic, assign) FLAAuthBiometric value; | ||
@end | ||
|
||
/// The codec used by FLALocalAuthApi. | ||
NSObject<FlutterMessageCodec> *FLALocalAuthApiGetCodec(void); | ||
|
||
@protocol FLALocalAuthApi | ||
/// Returns true if this device supports authentication. | ||
/// | ||
/// @return `nil` only when `error != nil`. | ||
- (nullable NSNumber *)isDeviceSupportedWithError:(FlutterError *_Nullable *_Nonnull)error; | ||
/// Returns true if this device can support biometric authentication, whether | ||
/// any biometrics are enrolled or not. | ||
/// | ||
/// @return `nil` only when `error != nil`. | ||
- (nullable NSNumber *)deviceCanSupportBiometricsWithError:(FlutterError *_Nullable *_Nonnull)error; | ||
/// Returns the biometric types that are enrolled, and can thus be used | ||
/// without additional setup. | ||
/// | ||
/// @return `nil` only when `error != nil`. | ||
- (nullable NSArray<FLAAuthBiometricWrapper *> *)getEnrolledBiometricsWithError: | ||
(FlutterError *_Nullable *_Nonnull)error; | ||
/// Attempts to authenticate the user with the provided [options], and using | ||
/// [strings] for any UI. | ||
- (void)authenticateWithOptions:(FLAAuthOptions *)options | ||
strings:(FLAAuthStrings *)strings | ||
completion:(void (^)(FLAAuthResultDetails *_Nullable, | ||
FlutterError *_Nullable))completion; | ||
@end | ||
|
||
extern void FLALocalAuthApiSetup(id<FlutterBinaryMessenger> binaryMessenger, | ||
NSObject<FLALocalAuthApi> *_Nullable api); | ||
|
||
NS_ASSUME_NONNULL_END |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.