[camera] Fix Android lint issues #3993
Conversation
Fixes the new lints that came with a recent AGP update, and removes the baseline file. Fixes flutter/flutter#126710 Part of flutter/flutter#88011
| @@ -34,7 +34,6 @@ android { | |||
| compileSdkVersion 33 | |||
|
|
|||
| defaultConfig { | |||
| targetSdkVersion 31 | |||
There was a problem hiding this comment.
I dont think you want to delete this but instead set it to 33
There was a problem hiding this comment.
No other plugin in the entire repository has this, and in some initial investigation I was not able to determine exactly how this interacts with app targetSdkVersion. If we want the plugins to have this, I think we should have a policy for what we set it to and how we test it, and tooling that enforces that (since if it does affect apps, we need to ensure that we are actually testing, in some cases manually, before we roll it forward).
There was a problem hiding this comment.
(For instance, does setting this change the compat behavior of every app that is a client of the plugin? If so, updating it to 33 is potentially a big deal for clients.)
There was a problem hiding this comment.
Filed flutter/flutter#126828 for us to track and discuss this.
There was a problem hiding this comment.
Sorry I didnt catch that this was a plugin and not an example app.
|
The camera test failure looks like unrelated flake; filed flutter/flutter#126830 |
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages, pr: 3993, due to - The status or check suite Linux plugin_tools_tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
camsim99
added
the
autosubmit
flutter/packages@6608b60...b971830 2023-05-16 [email protected] [camera] Fix Android lint issues (flutter/packages#3993) 2023-05-15 [email protected] [various] Update min macOS versions (flutter/packages#3987) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@6608b60...b971830 2023-05-16 [email protected] [camera] Fix Android lint issues (flutter/packages#3993) 2023-05-15 [email protected] [various] Update min macOS versions (flutter/packages#3987) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes the new lints that came with a recent AGP update, and removes the baseline file. Fixes flutter/flutter#126710 Part of flutter/flutter#88011
Fixes the new lints that came with a recent AGP update, and removes the baseline file.
Fixes flutter/flutter#126710
Part of flutter/flutter#88011
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.