[go_router] Fix some typos in the comments and asserts #4412
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I believe this can have the override: no versioning needed" label |
|
test-exempt: only affects comments, asserts, and non-user-facing debugging info |
chunhtai
added
the
override: no versioning needed
|
no version needed. Reason: fixing grammar or typo in doc. These errors do not impact readability too much. |
# Conflicts: # packages/go_router/CHANGELOG.md
chunhtai
added
the
autosubmit
flutter/packages@4469c5e...188a846 2023-07-11 [email protected] [go_router] Fix some typos in the comments and asserts (flutter/packages#4412) 2023-07-11 [email protected] [pigeon] `Object` type in class integration tests (flutter/packages#4384) 2023-07-11 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.22 to 1.9.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4419) 2023-07-10 [email protected] [ci] Add initial LUCI legacy analysis (flutter/packages#4428) 2023-07-10 [email protected] [web_benchmarks] Migrate custom test to `custom_package_tests` (flutter/packages#4429) 2023-07-10 [email protected] go_router: docs: fix typo in StatefulShellRoute.indexedStack(...) docs (flutter/packages#4341) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
While I'm working on making the
RouteMatchListaRouteMatchTree, I'm fixing some typos/inconsistency in the comments and the assert messages. This PR fixes some of them.List which issues are fixed by this PR. You must list at least one issue.
No issue but linked to https://docs.google.com/document/d/1HCgLi7ialw2Eqv-f_2z9ogdOfcmepIIqCsRhF-DT9dM/
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.