-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[pointer_interceptor] Remove iOS and Android from example #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pointer_interceptor] Remove iOS and Android from example #442
Conversation
The package is web-only, and doesn't build for other platforms, so the example shouldn't be configured for them. This may be a point of user confusion, but it also fails if we fix the repo script to build example apps (which it currently isn't, I believe due to a long-ago regression that hadn't been noticed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package is web-only, and doesn't build for other platforms
The package is only active in the web, but it should compile (and noop) in mobile platforms (see the conditional export here)
I remember running the example app on Android a while back, but maybe it has bit rotted since then? :S
Hm, I'll take another look. IIRC it was complaining about |
Thanks for taking another look, I might have screwed up the example since I've written it... or maybe its integration tests :S |
That's not the problem, this is
That line dates back to #256 so I'm not sure how you could ever have run the example on anything but web. So do you want to rewrite the example, or move forward with this PR? |
Gosh, you're right, that's bad...
Nah, let's move on with the PR and I'll look at adding an Android version later, since I need to reshuffle a bunch of code to make it work :/ |
Fix analyzer warnings and errors
The package is web-only, and the example doesn't build for other platforms,
so it shouldn't be configured for them.
This may be a point of user confusion, but it also fails if we fix the
repo script to build example apps (which it currently isn't, I believe
due to a long-ago regression that hadn't been noticed).
Pre-launch Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy.CHANGELOG.md
to add a description of the change.///
).