Skip to content

[webview_flutter] Add a method for getting the user agent #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 30, 2023
Merged

[webview_flutter] Add a method for getting the user agent #4472

merged 17 commits into from
Sep 30, 2023

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jul 14, 2023 •
edited
Loading

Aggregate PR for adding a method for retrieving the user agent.

Internal: b/272582342

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines added the federated: all_changes PR that contains changes for all packages for a federated plugin change label Jul 14, 2023
@bparrishMines bparrishMines changed the title Get uas [webview_flutter] Add a method for getting the user agent Jul 14, 2023
@bparrishMines bparrishMines marked this pull request as ready for review July 14, 2023 19:09
@bparrishMines bparrishMines requested review from stuartmorgan-g and removed request for ditman July 14, 2023 19:12
stuartmorgan-g
stuartmorgan-g requested changes Jul 17, 2023
View reviewed changes
..._android/android/src/main/java/io/flutter/plugins/webviewflutter/WebSettingsHostApiImpl.java Outdated
@@ -132,4 +132,11 @@ public void setTextZoom(@NonNull Long instanceId, @NonNull Long textZoom) {
final WebSettings webSettings = Objects.requireNonNull(instanceManager.getInstance(instanceId));
webSettings.setTextZoom(textZoom.intValue());
}

@Nullable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the underlying API really return a nullable string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out and it looks like it is always nonnull. Updated.

@ditman
Copy link
Member

ditman commented Jul 19, 2023

I'll keep an eye out for when this lands, the _web version of this should be very simple to add!

stuartmorgan-g
stuartmorgan-g approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines mentioned this pull request Jul 25, 2023
Merged
11 tasks
auto-submit bot pushed a commit that referenced this pull request Aug 15, 2023
@bparrishMines
[webview_flutter_platform_interface] Adds support for retrieving user…
93455e0 
… agent (#4563)

Platform interface portion of #4472
tony-hristov pushed a commit to tony-hristov/webview_flutter that referenced this pull request Sep 12, 2023
@bparrishMines
[webview_flutter_platform_interface] Adds support for retrieving user…
dafc8a1 
… agent (#4563)

Platform interface portion of flutter/packages#4472
@bparrishMines bparrishMines mentioned this pull request Sep 14, 2023
Merged
11 tasks
auto-submit bot pushed a commit that referenced this pull request Sep 29, 2023
@bparrishMines
[webview_flutter_android][webview_flutter_wkwebview] Adds support for…
b3138a6 
… `getUserAgent` for `webview_flutter` platform implementations (#4927)

Platform implementations for #4472
@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 30, 2023
@auto-submit auto-submit bot merged commit f68661d into flutter:main Sep 30, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2023
@engine-flutter-autoroll
f68661d [webview_flutter] Add a method for getting the user agent (fl…
7f46b71 
…utter/packages#4472)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 2, 2023
@engine-flutter-autoroll
Roll Packages from d0e9a0e to e2ac440 (12 revisions) (#135859)
0562f72 
flutter/packages@d0e9a0e...e2ac440

2023-10-01 [email protected] Roll Flutter from d3df8f6 to d42313c (4 revisions) (flutter/packages#5044)
2023-10-01 [email protected] [webview_flutter] Adds app facing implementation to override console log (flutter/packages#4705)
2023-09-30 [email protected] Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter/packages#5043)
2023-09-30 [email protected] [webview_flutter] Add a method for getting the user agent (flutter/packages#4472)
2023-09-29 [email protected] [webview_flutter_android] Fix race condition in flaky test (flutter/packages#5037)
2023-09-29 [email protected] [ci] Wait for LUCI test checkin in `release` (flutter/packages#4911)
2023-09-29 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Adds support for `getUserAgent` for `webview_flutter` platform implementations (flutter/packages#4927)
2023-09-29 [email protected] [ci] Disable maps tests in Android emulator (flutter/packages#5003)
2023-09-29 [email protected] [camera] Dispose resources correctly on setDescription (flutter/packages#4003)
2023-09-29 [email protected] [webview_flutter_android] Adds Android implementation to override console log (flutter/packages#4702)
2023-09-29 [email protected] [camera] Remove `@throw` from iOS implementation (flutter/packages#5034)
2023-09-29 [email protected] Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) (flutter/packages#5036)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@bparrishMines bparrishMines deleted the getUAS branch October 2, 2023 17:30
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Packages from d0e9a0e to e2ac440 (12 revisions) (flutter#135859)
3a11781 
flutter/packages@d0e9a0e...e2ac440

2023-10-01 [email protected] Roll Flutter from d3df8f6 to d42313c (4 revisions) (flutter/packages#5044)
2023-10-01 [email protected] [webview_flutter] Adds app facing implementation to override console log (flutter/packages#4705)
2023-09-30 [email protected] Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter/packages#5043)
2023-09-30 [email protected] [webview_flutter] Add a method for getting the user agent (flutter/packages#4472)
2023-09-29 [email protected] [webview_flutter_android] Fix race condition in flaky test (flutter/packages#5037)
2023-09-29 [email protected] [ci] Wait for LUCI test checkin in `release` (flutter/packages#4911)
2023-09-29 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Adds support for `getUserAgent` for `webview_flutter` platform implementations (flutter/packages#4927)
2023-09-29 [email protected] [ci] Disable maps tests in Android emulator (flutter/packages#5003)
2023-09-29 [email protected] [camera] Dispose resources correctly on setDescription (flutter/packages#4003)
2023-09-29 [email protected] [webview_flutter_android] Adds Android implementation to override console log (flutter/packages#4702)
2023-09-29 [email protected] [camera] Remove `@throw` from iOS implementation (flutter/packages#5034)
2023-09-29 [email protected] Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) (flutter/packages#5036)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@bparrishMines @HugoOlthof
[webview_flutter_android][webview_flutter_wkwebview] Adds support for…
7da4126 
… `getUserAgent` for `webview_flutter` platform implementations (flutter#4927)

Platform implementations for flutter#4472
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@bparrishMines @HugoOlthof
[webview_flutter] Add a method for getting the user agent (flutter#4472)
90cf9e9 
Aggregate PR for adding a method for retrieving the user agent. 

Internal: b/272582342
bill-skdnd pushed a commit to skdnd-metaspace/webview_flutter_wkwebview that referenced this pull request Aug 2, 2024
@bparrishMines
[webview_flutter_android][webview_flutter_wkwebview] Adds support for…
582e9dd 
… `getUserAgent` for `webview_flutter` platform implementations (#4927)

Platform implementations for flutter/packages#4472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App federated: all_changes PR that contains changes for all packages for a federated plugin change p: webview_flutter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bparrishMines @ditman @stuartmorgan-g