[ci] Simplify Dockerfile #4530
Merged
[ci] Simplify Dockerfile #4530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the things installed by the Dockerfile are for tests that have moved to LUCI, so are no longer used. This simlifies down to just the FTL requirements while we work on that final conversion.
stuartmorgan-g
commented
Jul 20, 2023
| @@ -1,7 +1,6 @@ | |||
| # The Flutter version is not important here, since the CI scripts update Flutter | |||
| # before running. What matters is that the base image is pinned to minimize | |||
| # unintended changes when modifying this file. | |||
| # This is the hash for the 3.0.0 image. | |||
There was a problem hiding this comment.
This was very stale; dependabot manages the next line now, not humans.
tarrinneal
approved these changes
Jul 20, 2023
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages, pr: 4530, due to - The status or check suite Linux_android android_build_all_packages master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 21, 2023
flutter/packages@674179f...2266a76 2023-07-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.4 to 2.21.0 (flutter/packages#4525) 2023-07-20 [email protected] [url_launcher_android] Set `buildFeatures.buildConfig` to true for compatibility with AGP 8.0+ (flutter/packages#4535) 2023-07-20 [email protected] [go_router] fix error handling page link (flutter/packages#4296) 2023-07-20 [email protected] [plugin_platform_interface] Adopt code-excerpts (flutter/packages#4534) 2023-07-20 [email protected] [ci] Simplify Dockerfile (flutter/packages#4530) 2023-07-20 [email protected] [ci] Enable Windows Dart unit test sharding (flutter/packages#4528) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
flutter/packages@674179f...2266a76 2023-07-21 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.4 to 2.21.0 (flutter/packages#4525) 2023-07-20 [email protected] [url_launcher_android] Set `buildFeatures.buildConfig` to true for compatibility with AGP 8.0+ (flutter/packages#4535) 2023-07-20 [email protected] [go_router] fix error handling page link (flutter/packages#4296) 2023-07-20 [email protected] [plugin_platform_interface] Adopt code-excerpts (flutter/packages#4534) 2023-07-20 [email protected] [ci] Simplify Dockerfile (flutter/packages#4530) 2023-07-20 [email protected] [ci] Enable Windows Dart unit test sharding (flutter/packages#4528) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the things installed by the Dockerfile are for tests that have moved to LUCI, so are no longer used. This simlifies down to just the FTL requirements while we work on that final conversion.