Skip to content

[cross_file] Document mime type is not made for io implementations #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ValentinVignal
Copy link
Contributor

@ValentinVignal ValentinVignal commented Jul 22, 2023

Fixes flutter/flutter#93379

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ValentinVignal
Copy link
Contributor Author

That "fix" seems a bit "small" / "light" to me.

Can you help me figure out what else should be good to be done about that?

@ditman
Copy link
Member

ditman commented Jul 24, 2023

@ValentinVignal this is very similar to #4416, any chance of collaborating with @andreacioni to render all doc improvements to cross_file in a single, coordinated push? Thanks!

@andreacioni
Copy link
Contributor

Hello, no problem for me. I can integrate your changes in my PR @ValentinVignal .

Let me know if this solution works for you 😊

@ValentinVignal
Copy link
Contributor Author

Should I create the PR on your branch then @andreacioni ?

@andreacioni
Copy link
Contributor

Yeah, I think it would work. Feel free to open it.

@ValentinVignal
Copy link
Contributor Author

Closing in favor of andreacioni#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cross_file] Document that mimeType is not expected to be set for io implementation
3 participants