-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[cross_file] Document mime type is not made for io implementations #4549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cross_file] Document mime type is not made for io implementations #4549
Conversation
That "fix" seems a bit "small" / "light" to me. Can you help me figure out what else should be good to be done about that? |
@ValentinVignal this is very similar to #4416, any chance of collaborating with @andreacioni to render all doc improvements to |
Hello, no problem for me. I can integrate your changes in my PR @ValentinVignal . Let me know if this solution works for you 😊 |
Should I create the PR on your branch then @andreacioni ? |
Yeah, I think it would work. Feel free to open it. |
…-that-mime-type-is-not-for-io
Closing in favor of andreacioni#1 |
Fixes flutter/flutter#93379
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.