-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Tooling] Add google owned cache for dependencies as an option in ci #4567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a38111d
Proof of concepts of a package using artifact hub.
reidbaker befa254
Update documentation, split out plugin apply into setting, simplify r…
reidbaker 73aea86
Update the env variable to be more specific
reidbaker a2e87fb
Speling and phrasing updates, make key a variable
reidbaker 474f547
formatting
reidbaker 4747b49
Merge branch 'main' into i120119-artifact-hub-poc
reidbaker 797e066
Update changelog
reidbaker f249971
Merge branch 'main' into i120119-artifact-hub-poc
reidbaker 81b0406
Update GRADLE_STRUCTURE.md to use CI instead of ci
reidbaker a996c06
Update GRADLE_STRUCTURE.md
reidbaker 2adfc43
Merge branch 'main' into i120119-artifact-hub-poc
reidbaker 3ce0495
Update CHANGELOG.md to not have comment
reidbaker 6fc5753
Delete GRADLE_STRUCTURE.md
reidbaker 384541e
Update build.gradle
reidbaker 621aee2
Update settings.gradle
reidbaker 875b078
Merge branch 'main' into i120119-artifact-hub-poc
reidbaker 77266fd
Merge branch 'main' into i120119-artifact-hub-poc
reidbaker 23e9840
Merge branch 'main' into i120119-artifact-hub-poc
reidbaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Gradle Structure | ||
|
||
`package/example/android/settings.gradle` imports the flutter tooling and includes the `app` directory and it configures GoogleCloudPlatform/artifact-registry-maven-tools for use in ci. | ||
reidbaker marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
This repo has a GCP instance that mirrors dependencies available from `google()` and `mavenCentral()` used by ci (or googlers). This gives us redudent uptime for dependency availability. | ||
reidbaker marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Using this cache is not intended or avaiable for contributors outside of CI. We protect that execution with an environment variable ARTIFACT_HUB to ensure that by default users do not see rejected cloud credentials or errors in builds. | ||
|
||
Googlers can debug locally by setting ARTIFACT_HUB to the valid artifact hub value and authenticating with GCP. To authenticate run `gcloud auth application-default login`. To find artifact hub url use `<url>` section of go/artifact-hub#maven or inspect the value on CI servers. CI uses a service account for billing. That is defined in go/artifact-hub-service-account (googler access only). | ||
|
||
## Useful links for debuging | ||
https://github.com/GoogleCloudPlatform/artifact-registry-maven-tools/blob/master/README.md | ||
https://docs.gradle.org/current/userguide/declaring_repositories.html | ||
https://docs.gradle.org/current/userguide/viewing_debugging_dependencies.html | ||
|
||
Comamnd to force refresh of dependencies `./gradlew app:dependencies --configuration <SOME_TASK> --refresh-dependencies` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having seen the details here, I think a wiki page referenced from https://github.com/flutter/flutter/wiki/Understanding-Packages-tests#external-build-dependencies and maybe https://github.com/flutter/flutter/wiki/Plugins-and-Packages-repository-structure would probably be better than an md file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok in that case consider the md files content for review and I will remove and update the wiki before merging.