Skip to content

remove unneeded imports #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2023
Merged

remove unneeded imports #4579

merged 2 commits into from
Jul 28, 2023

Conversation

tarrinneal
Copy link
Contributor

Removes some unneeded imports and the ignores that go with them.

@tarrinneal
Copy link
Contributor Author

This should be exempt from versioning and tests.

@ditman
Copy link
Member

ditman commented Jul 28, 2023

This should be exempt from versioning and tests.

Agreed!

@ditman ditman added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jul 28, 2023
@tarrinneal tarrinneal changed the title remove unneeded ignores remove unneeded imports Jul 28, 2023
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up!

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2023
@auto-submit auto-submit bot merged commit 10aab44 into flutter:main Jul 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 28, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 28, 2023
flutter/packages@f4ae933...10aab44

2023-07-28 [email protected] remove unneeded imports (flutter/packages#4579)
2023-07-27 [email protected] [camerax] Wrap classes to implement resolution configuration for image capture, image analysis, and preview (flutter/packages#4523)
2023-07-27 [email protected] [camera_android] Provides a default exposure point if null. (flutter/packages#3851)
2023-07-27 [email protected] Roll Flutter from 61fd11d to dd9764e (5 revisions) (flutter/packages#4577)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
flutter/packages@f4ae933...10aab44

2023-07-28 [email protected] remove unneeded imports (flutter/packages#4579)
2023-07-27 [email protected] [camerax] Wrap classes to implement resolution configuration for image capture, image analysis, and preview (flutter/packages#4523)
2023-07-27 [email protected] [camera_android] Provides a default exposure point if null. (flutter/packages#3851)
2023-07-27 [email protected] Roll Flutter from 61fd11d to dd9764e (5 revisions) (flutter/packages#4577)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
flutter/packages@f4ae933...10aab44

2023-07-28 [email protected] remove unneeded imports (flutter/packages#4579)
2023-07-27 [email protected] [camerax] Wrap classes to implement resolution configuration for image capture, image analysis, and preview (flutter/packages#4523)
2023-07-27 [email protected] [camera_android] Provides a default exposure point if null. (flutter/packages#3851)
2023-07-27 [email protected] Roll Flutter from 61fd11d to dd9764e (5 revisions) (flutter/packages#4577)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera p: pigeon p: url_launcher p: video_player p: webview_flutter platform-android platform-ios platform-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants